Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 98642 invoked from network); 14 Dec 2006 08:00:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Dec 2006 08:00:00 -0000 Received: (qmail 78192 invoked by uid 500); 14 Dec 2006 08:00:04 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 78156 invoked by uid 500); 14 Dec 2006 08:00:04 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 78144 invoked by uid 99); 14 Dec 2006 08:00:04 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2006 00:00:04 -0800 X-ASF-Spam-Status: No, hits=3.5 required=10.0 tests=FROM_HAS_MIXED_NUMS,HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of c1vamsi1c@gmail.com designates 64.233.182.185 as permitted sender) Received: from [64.233.182.185] (HELO nf-out-0910.google.com) (64.233.182.185) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Dec 2006 23:59:53 -0800 Received: by nf-out-0910.google.com with SMTP id x37so724223nfc for ; Wed, 13 Dec 2006 23:59:32 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=TyHyZKuXYofXl3PEfjVs5Uj9ufh14iB52OxSmIKBM/woLZMlttp6NNLYIQYb4Hr6+AnAaaeD6uuprl35Yy4OsEPbSCkg9g1kQ+N2EFlQWcnROtR+Arg1CnLq+p+SqyC58PQtmEiJ+s391D7chKnnAtWiuKhmu1Ekm6qT9JyjBK0= Received: by 10.49.42.5 with SMTP id u5mr401820nfj.1166083172146; Wed, 13 Dec 2006 23:59:32 -0800 (PST) Received: by 10.49.11.12 with HTTP; Wed, 13 Dec 2006 23:59:32 -0800 (PST) Message-ID: <22d56c4d0612132359m52a46a15p47ae1148139bdd93@mail.gmail.com> Date: Thu, 14 Dec 2006 13:29:32 +0530 From: "Vamsavardhana Reddy" To: dev@geronimo.apache.org Subject: Re: svn commit: r487020 - /geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java In-Reply-To: <22d56c4d0612132335n47152fbflf1322f8bae0565dd@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_2618_19624486.1166083172092" References: <20061214065455.AE03C1A981A@eris.apache.org> <22d56c4d0612132335n47152fbflf1322f8bae0565dd@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_2618_19624486.1166083172092 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Fixed in r487099. On 12/14/06, Vamsavardhana Reddy wrote: > > On 12/14/06, hogstrom@apache.org wrote: > > > > Author: hogstrom > > Date: Wed Dec 13 22:54:54 2006 > > New Revision: 487020 > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=487020 > > Log: > > Applying r486567 from trunk ( 2.0-SNAPSHOT) > > > > Modified: > > > > geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java > > > > Modified: > > geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java > > > > URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java?view=diff&rev=487020&r1=487019&r2=487020 > > > > > > ============================================================================== > > --- > > geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java > > (original) > > +++ > > geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java > > Wed Dec 13 22:54:54 2006 > > @@ -700,7 +700,7 @@ > > } > > UrlPatternType[] urlPatterns = > > servletMappingType.getUrlPatternArray(); > > for (int j = 0; j < urlPatterns.length; j++) { > > - String urlPattern = urlPatterns[j].getStringValue(); > > + String urlPattern = > > urlPatterns[j].getStringValue()i.trim(); > > > Won't the above line result in compilation error? > > if (!knownServletMappings.contains(urlPattern)) { > > knownServletMappings.add(urlPattern); > > checkString(urlPattern); > > > > > > > ------=_Part_2618_19624486.1166083172092 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Fixed in r487099.
 

On 12/14/06, Vamsavardhana Reddy <c1vamsi1c@gmail.com> wrote:
On 12/14/06, hogstrom@apache.org <hogstrom@apache.org> wrote:
Author: hogstrom
Date: Wed Dec 13 22:54:54 2006
New Revision: 487020

URL: http://svn.apache.org/viewvc?view=rev&rev=487020
Log:
Applying r486567 from trunk ( 2.0-SNAPSHOT)

Modified:
    geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java

Modified: geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java?view=diff&rev=487020&r1=487019&r2=487020
==============================================================================
--- geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java (original)
+++ geronimo/server/branches/2.0-M1/modules/geronimo-jetty6-builder/src/main/java/org/apache/geronimo/jetty6/deployment/JettyModuleBuilder.java Wed Dec 13 22:54:54 2006
@@ -700,7 +700,7 @@
             }
             UrlPatternType[] urlPatterns = servletMappingType.getUrlPatternArray();
             for (int j = 0; j < urlPatterns.length; j++) {
-                String urlPattern = urlPatterns[j].getStringValue();
+                String urlPattern = urlPatterns[j].getStringValue()i.trim();

Won't the above line result in compilation error? 

                 if (!knownServletMappings.contains(urlPattern)) {
                     knownServletMappings.add(urlPattern);
                     checkString(urlPattern);




------=_Part_2618_19624486.1166083172092--