Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (herse.apache.org: domain of david.blevins@visi.com
 designates 208.42.156.2 as permitted sender)
Mime-Version: 1.0 (Apple Message framework v752.3)
In-Reply-To: <22d56c4d0612190623m4a57cd3ree37261a65390ae6@mail.gmail.com>
References: <20061215203417.779B41A981A@eris.apache.org>
 <8B2A6358-8348-4833-A780-EF5718CE2661@planet57.com>
 <E210AC06-6761-4FFE-94FC-A8579003738D@hogstrom.org>
 <22d56c4d0612190623m4a57cd3ree37261a65390ae6@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <04DFD4DD-4B48-48AF-89BA-E641321B4C77@visi.com>
Content-Transfer-Encoding: 7bit
From: David Blevins <david.blevins@visi.com>
Subject: Re: svn commit: r487651 - /geronimo/server/trunk/pom.xml
Date: Tue, 19 Dec 2006 12:23:17 -0800
To: dev@geronimo.apache.org


On Dec 19, 2006, at 6:23 AM, Vamsavardhana Reddy wrote:

>
>
> On 12/16/06, Matt Hogstrom <matt@hogstrom.org> wrote:
> On Dec 15, 2006, at 3:57 PM, Jason Dillon wrote:
>
> > Yikes... what happened on this change?
> >
> > The diff shows a lot more changed than just what was indicated in
> > the comment...
> >
>
> Ya, looks like a formatting change.  A diff before would help :)  I
> too am guilty of transgressions like this.  Thanks for the reminder.
>
> I check the diff on each file before checkin and eliminate all  
> unnecessary changes (like line with spaces replacing blank lines  
> etc.).  It costs some extra time :o(, but, keeps the commit clean.   
> I hope that my energy will last for some more time :o)

I usually do as Jason suggested and check my "beauty" diff in first.   
That is if I notice the formatting is not right before I start  
editing :)

-David