geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-2653) Inconsistencies between jetty6-builder and tomcat6-builder plan.xml files
Date Wed, 13 Dec 2006 00:11:23 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2653?page=comments#action_12457958 ] 
            
David Jencks commented on GERONIMO-2653:
----------------------------------------

Please give a little more context in the future.... I think the plan extracts are from defaultEnvironment
attributes??  

IMO the tomcat6-builder defaultEnvironment should not need to include j2ee-server as long
as tomcat6 depends on it.

The tomcat6 deployer shold include the CXFBuilder pattern and the UnavailableWebServiceBuilder
should be removed and WebServiceBuilder should be renamed Axis1Builder.

I recently added some capability for multiple ws builders to coexist with the expectation
that each builder would only deploy stuff it recognizes.  This should allow us to be able
to support jaxrpc using axis1 and jaxws using cxf/axis2 at the same time.  I haven't tested
this.   I'm working on a simple cxf integration test which I hope to commit soon.... maybe
we can expand it to a better test for this stuff too.


> Inconsistencies between jetty6-builder and tomcat6-builder plan.xml files
> -------------------------------------------------------------------------
>
>                 Key: GERONIMO-2653
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2653
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0
>            Reporter: Jarek Gawor
>
> 1) One of the plans has an extra dependency on the j2ee-server module while the other
does not (enough though both tomcat6/pom.xml and jetty6/pom.xml have dependency on j2ee-server
module):
> tomcat6-deployer/src/plan/plan.xml contains:
>                 <dependencies>
>                     <dependency>
>                         <groupId>${pom.groupId}</groupId>
>                         <artifactId>j2ee-server</artifactId>
>                         <type>car</type>
>                     </dependency>
>                     <dependency>
>                         <groupId>${pom.groupId}</groupId>
>                         <artifactId>tomcat6</artifactId>
>                         <type>car</type>
>                     </dependency>
>                 </dependencies>           
> while jetty6-deployer/src/plan/plan.xml contains:
>                 <dependencies>
>                     <dependency>
>                         <groupId>${pom.groupId}</groupId>
>                         <artifactId>jetty6</artifactId>
>                         <type>car</type>
>                     </dependency>
>                 </dependencies>
> 2) Also, jetty6-deployer specifies CXFBuilder: 
>         <references name="WebServiceBuilder">
>             <pattern>
>                 <name>CXFBuilder</name>
>             </pattern>
>             <pattern>
>                 <name>WebServiceBuilder</name>
>             </pattern>
>             <pattern>
>                 <name>UnavailableWebServiceBuilder</name>
>             </pattern>
>         </references>
> while tomcat6-deployer does not:
>         <references name="WebServiceBuilder">
>             <pattern>
>                 <name>WebServiceBuilder</name>
>             </pattern>
>             <pattern>
>                 <name>UnavailableWebServiceBuilder</name>
>             </pattern>
>         </references>
> It seems to me like these things should be consistent (unless of course there is a good
reason for it). 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message