geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh Midha (JIRA)" <j...@apache.org>
Subject [jira] Updated: (GERONIMO-1642) Deployment plan namespace validation
Date Mon, 18 Dec 2006 08:48:23 GMT
     [ http://issues.apache.org/jira/browse/GERONIMO-1642?page=all ]

Rakesh Midha updated GERONIMO-1642:
-----------------------------------

       Patch Info: [Patch Available]
    Fix Version/s: 2.0
                       (was: 1.1.x)
         Assignee:     (was: Rakesh Midha)


Hello David

You are right, in number of cases it is already fixed, but there are still few cases where
it is a problem. Though I didnt like the way it is fixed in geronimo-web.xml, via revision
406804. In a way it hardcodes the namespace which I didnt like.

Anyways for failing cases, geronimo-application.xml, openejb-jar.xml and application-client
I attached to patch, which actually doesn't check for any particular version of schema but
just validates the root element, and if root element or namespace is wrong it throws 

Cannot find desiredElement "application" with
namespace{http://geronimo.apache.org/xml/ns/j2ee/application-1.2} in
the plan provided.

What do you say? Can you please review it and commit it. It is just short changes and will
not take your lot of time. (small amount of changes, but one of those cases where it take
lot of time to find the place where fix should go :-) )

Mark patch available and unassigning.

Thanks
Rakesh

> Deployment plan namespace validation
> ------------------------------------
>
>                 Key: GERONIMO-1642
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1642
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: web, deployment, OpenEJB
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>            Priority: Critical
>             Fix For: 2.0
>
>         Attachments: namespace1642.patch
>
>
> When you deploy with a geronimo deployment plan packaged in the archive, but it has the
wrong namespace, the file is ignored.  If anything, you get a message saying the plan is required,
or that the archive is not a WAR/JAR/etc.  We should have special detection for geronimo-application.xml,
geronimo-ra.xml, geronimo-web.xml, and openejb-jar.xml that notices if the file is present
but has the wrong namespace, and prints a suggestive WARN or ERROR message to the console.
 Probably for the application.xml, web.xml, ra.xml, and ejb-jar.xml too.
> People have asked for help on the mailing list several times recently when they had this
(bad namespace) problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message