geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vamsavardhana Reddy" <c1vams...@gmail.com>
Subject Re: svn commit: r488326 - /geronimo/server/tags/2.0-M1/testsuite/deployment-testsuite/manifestcp/manifestcp-ejb/src/main/resources/META-INF/ejb-jar.xml
Date Tue, 19 Dec 2006 14:09:20 GMT
I agree with Jason.  We should not be changing code once tagged.

--vamsi


On 12/19/06, Jason Dillon <jason@planet57.com> wrote:
>
> Ugh... this is why I don't like all that moving of branches to tags...
>
> A "tag" or "label" should never be modified... its a point in time,
> not indented (or expected) to be changed.
>
> I believe that we would be doing ourselves a major favor by following
> some SCM best practices... moving branches to tags is not one of
> them... neither is changing code in a tag.
>
> --jason
>
>
> On Dec 18, 2006, at 8:35 AM, kevan@apache.org wrote:
>
> > Author: kevan
> > Date: Mon Dec 18 08:35:24 2006
> > New Revision: 488326
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=488326
> > Log:
> > add missing license header
> >
> > Modified:
> >     geronimo/server/tags/2.0-M1/testsuite/deployment-testsuite/
> > manifestcp/manifestcp-ejb/src/main/resources/META-INF/ejb-jar.xml
> >
> > Modified: geronimo/server/tags/2.0-M1/testsuite/deployment-
> > testsuite/manifestcp/manifestcp-ejb/src/main/resources/META-INF/ejb-
> > jar.xml
> > URL: http://svn.apache.org/viewvc/geronimo/server/tags/2.0-M1/
> > testsuite/deployment-testsuite/manifestcp/manifestcp-ejb/src/main/
> > resources/META-INF/ejb-jar.xml?
> > view=diff&rev=488326&r1=488325&r2=488326
> > ======================================================================
> > ========
> > --- geronimo/server/tags/2.0-M1/testsuite/deployment-testsuite/
> > manifestcp/manifestcp-ejb/src/main/resources/META-INF/ejb-jar.xml
> > (original)
> > +++ geronimo/server/tags/2.0-M1/testsuite/deployment-testsuite/
> > manifestcp/manifestcp-ejb/src/main/resources/META-INF/ejb-jar.xml
> > Mon Dec 18 08:35:24 2006
> > @@ -1,4 +1,20 @@
> >  <?xml version="1.0" encoding="UTF-8"?>
> > +<!--
> > +  Licensed to the Apache Software Foundation (ASF) under one or more
> > +  contributor license agreements.  See the NOTICE file distributed
> > with
> > +  this work for additional information regarding copyright ownership.
> > +  The ASF licenses this file to You under the Apache License,
> > Version 2.0
> > +  (the "License"); you may not use this file except in compliance
> > with
> > +  the License.  You may obtain a copy of the License at
> > +
> > +      http://www.apache.org/licenses/LICENSE-2.0
> > +
> > +  Unless required by applicable law or agreed to in writing, software
> > +  distributed under the License is distributed on an "AS IS" BASIS,
> > +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied.
> > +  See the License for the specific language governing permissions and
> > +  limitations under the License.
> > +-->
> >  <ejb-jar version="2.1"
> >           xmlns="http://java.sun.com/xml/ns/j2ee"
> >           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> >
> >
>
>

Mime
View raw message