geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <david_jen...@yahoo.com>
Subject Re: svn commit: r483773 - in /geronimo/server/trunk: ./ applications/console/geronimo-console-standard/ applications/geronimo-examples/geronimo-jsp-examples/ configs/webconsole-jetty6/ configs/webconsole-jetty6/src/plan/ configs/webconsole-tomcat/ co
Date Mon, 11 Dec 2006 18:09:54 GMT

On Dec 11, 2006, at 9:18 AM, Joe Bohn wrote:

> David,
>
> I wanted to get something committed that works for now.  With trunk  
> rev. 485719 I included jstl as a dependency in modules/geronimo- 
> web-2.5-builder as well as in configs/jetty6 and configs/tomcat6 so  
> that it would always be in the classpath for an application.  I can  
> change this if there is a better way.

oops getting behind on my email....

in the jetty6-deployer plan in the JettyWebBuilder gbean config  
there's a defaultEnvironment xml attribute.  If you add the jstl  
dependency to

                 <dependencies>
                     <dependency>
                         <groupId>${pom.groupId}</groupId>
                         <artifactId>jetty6</artifactId>
                         <type>car</type>
                     </dependency>
                 </dependencies>


I think it will be added to every web app deployed to jetty6.   
However this will result in each web app getting its own copy of  
jstl.  If it would be better to share a copy of jstl among all web  
apps we could either
- include it in the jetty6 config classpath (IIUC this is what you  
are currently doing).  However jetty doesn't need it so this may not  
be ideal in some theoretical sense.
- make a jstl config including only (??) the jstl jar and include a  
dependency on that config
- if jstl can only be used from jsps (??? displaying my total  
ignorance here :-))  maybe we could make a jasper config and include  
jstl there and put the jasper stuff in the defaultEnvironment.

Hope this clarifies what I was explaining poorly :-)

thanks
david jencks


>
> Thanks,
> Joe
>
>
> Joe Bohn wrote:
>> David,
>> I need a little direction.
>> I know that there is someplace/way to add a dependency for the  
>> default environment.  Such a dependency is then added dynamically  
>> to the module that is being deployed.  At least I think that is  
>> what I recall hearing you mention before.  But I'm having trouble  
>> finding the right place to add these dependencies.
>> I tried adding the dependencies to the pom for modules/geronimo- 
>> web-2.5-builder but they didn't carry over to the deployed  
>> module.  I also tried adding them to modules/geronimo-jetty6- 
>> builder and modules/geronimo-tomcat-builder with the same poor  
>> results.  Adding them to the builders allowed me to deploy the  
>> applications successfully but the jars were never added to the  
>> deployed module's classpath and so the applications can't run.
>> I'm sure I could force it to work if I added the dependencies  
>> directly in configs/tomcat and configs/jetty6 but that doesn't  
>> seem right since neither tomcat or jetty require the JSTL jars ...  
>> it's really the deployed applications running in these containers  
>> that might need them.
>> Thanks in advance for your help,
>> Joe
>> Joe Bohn wrote:
>>>
>>> Yes, Paul is correct.  It's not a spec jar so I'll include it in  
>>> the default environment for the builder as David recommends.
>>>
>>> Thanks,
>>> Joe
>>>
>>>
>>> David Jencks wrote:
>>>
>>>>
>>>> On Dec 8, 2006, at 12:48 AM, Paul McMahan wrote:
>>>>
>>>>> Should the JSTL classes be made available in the web container  
>>>>> instead
>>>>> of being included in the web apps? Looking at the spec that  
>>>>> seems to
>>>>> be the case.
>>>>
>>>>
>>>>
>>>>
>>>> If this is a spec jar then according to current convention it  
>>>> should  be included in the dependencies of the spec car.  If not  
>>>> it should be  included in the default environment for each web  
>>>> builder.
>>>>
>>>> thanks
>>>> david jencks
>>>>
>>>>>
>>>>> Best wishes,
>>>>> Paul
>>>>>
>>>>> On 12/7/06, jbohn@apache.org <jbohn@apache.org> wrote:
>>>>>
>>>>>> Author: jbohn
>>>>>> Date: Thu Dec  7 17:53:34 2006
>>>>>> New Revision: 483773
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=483773
>>>>>> Log:
>>>>>> GERONIMO-2536 Update jetty6 and tomcat jee5 assemblies to  
>>>>>> include  jstl 1.2 from glassfish
>>>>>> Also update jspc-maven-plugin to 1.4.7-SNAPSHOT to pick up   
>>>>>> jgenender's inclusion of jasper 6 (Thanks Jeff)
>>>>>>
>>>>>> Modified:
>>>>>>     geronimo/server/trunk/applications/console/geronimo- 
>>>>>> console- standard/pom.xml
>>>>>>     geronimo/server/trunk/applications/geronimo-examples/ 
>>>>>> geronimo- jsp-examples/pom.xml
>>>>>>     geronimo/server/trunk/configs/webconsole-jetty6/pom.xml
>>>>>>     geronimo/server/trunk/configs/webconsole-jetty6/src/plan/ 
>>>>>> plan.xml
>>>>>>     geronimo/server/trunk/configs/webconsole-tomcat/pom.xml
>>>>>>     geronimo/server/trunk/configs/webconsole-tomcat/src/plan/ 
>>>>>> plan.xml
>>>>>>     geronimo/server/trunk/pom.xml
>>>>>>
>>>>>> Modified: geronimo/server/trunk/applications/console/geronimo-  
>>>>>> console-standard/pom.xml
>>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/  
>>>>>> applications/console/geronimo-console-standard/pom.xml?  
>>>>>> view=diff&rev=483773&r1=483772&r2=483773
>>>>>> =================================================================

>>>>>> ==== =========
>>>>>> --- geronimo/server/trunk/applications/console/geronimo- 
>>>>>> console- standard/pom.xml (original)
>>>>>> +++ geronimo/server/trunk/applications/console/geronimo- 
>>>>>> console- standard/pom.xml Thu Dec  7 17:53:34 2006
>>>>>> @@ -131,7 +131,7 @@
>>>>>>          </dependency>
>>>>>>
>>>>>>          <dependency>
>>>>>> -            <groupId>javax.servlet</groupId>
>>>>>> +            <groupId>jstl</groupId>
>>>>>>              <artifactId>jstl</artifactId>
>>>>>>              <scope>provided</scope>
>>>>>>          </dependency>
>>>>>>
>>>>>> Modified: geronimo/server/trunk/applications/geronimo- 
>>>>>> examples/ geronimo-jsp-examples/pom.xml
>>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/  
>>>>>> applications/geronimo-examples/geronimo-jsp-examples/pom.xml?  
>>>>>> view=diff&rev=483773&r1=483772&r2=483773
>>>>>> =================================================================

>>>>>> ==== =========
>>>>>> --- geronimo/server/trunk/applications/geronimo-examples/ 
>>>>>> geronimo- jsp-examples/pom.xml (original)
>>>>>> +++ geronimo/server/trunk/applications/geronimo-examples/ 
>>>>>> geronimo- jsp-examples/pom.xml Thu Dec  7 17:53:34 2006
>>>>>> @@ -53,7 +53,7 @@
>>>>>>          </dependency>
>>>>>>
>>>>>>          <dependency>
>>>>>> -            <groupId>javax.servlet</groupId>
>>>>>> +            <groupId>jstl</groupId>
>>>>>>              <artifactId>jstl</artifactId>
>>>>>>          </dependency>
>>>>>>
>>>>>>
>>>>>> Modified: geronimo/server/trunk/configs/webconsole-jetty6/pom.xml
>>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>>>>> configs/ webconsole-jetty6/pom.xml? 
>>>>>> view=diff&rev=483773&r1=483772&r2=483773
>>>>>> =================================================================

>>>>>> ==== =========
>>>>>> --- geronimo/server/trunk/configs/webconsole-jetty6/pom.xml   
>>>>>> (original)
>>>>>> +++ geronimo/server/trunk/configs/webconsole-jetty6/pom.xml  
>>>>>> Thu  Dec  7 17:53:34 2006
>>>>>> @@ -181,7 +181,7 @@
>>>>>>          </dependency>
>>>>>>
>>>>>>          <dependency>
>>>>>> -            <groupId>javax.servlet</groupId>
>>>>>> +            <groupId>jstl</groupId>
>>>>>>              <artifactId>jstl</artifactId>
>>>>>>          </dependency>
>>>>>>
>>>>>>
>>>>>> Modified: geronimo/server/trunk/configs/webconsole-jetty6/src/ 
>>>>>> plan/ plan.xml
>>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>>>>> configs/ webconsole-jetty6/src/plan/plan.xml?  
>>>>>> view=diff&rev=483773&r1=483772&r2=483773
>>>>>> =================================================================

>>>>>> ==== =========
>>>>>> --- geronimo/server/trunk/configs/webconsole-jetty6/src/plan/  
>>>>>> plan.xml (original)
>>>>>> +++ geronimo/server/trunk/configs/webconsole-jetty6/src/plan/  
>>>>>> plan.xml Thu Dec  7 17:53:34 2006
>>>>>> @@ -75,7 +75,7 @@
>>>>>>                      <type>jar</type>
>>>>>>                  </dependency>
>>>>>>                  <dependency>
>>>>>> -                    <groupId>javax.servlet</groupId>
>>>>>> +                    <groupId>jstl</groupId>
>>>>>>                      <artifactId>jstl</artifactId>
>>>>>>                      <type>jar</type>
>>>>>>                  </dependency>
>>>>>>
>>>>>> Modified: geronimo/server/trunk/configs/webconsole-tomcat/pom.xml
>>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>>>>> configs/ webconsole-tomcat/pom.xml? 
>>>>>> view=diff&rev=483773&r1=483772&r2=483773
>>>>>> =================================================================

>>>>>> ==== =========
>>>>>> --- geronimo/server/trunk/configs/webconsole-tomcat/pom.xml   
>>>>>> (original)
>>>>>> +++ geronimo/server/trunk/configs/webconsole-tomcat/pom.xml  
>>>>>> Thu  Dec  7 17:53:34 2006
>>>>>> @@ -182,7 +182,7 @@
>>>>>>          </dependency>
>>>>>>
>>>>>>          <dependency>
>>>>>> -            <groupId>javax.servlet</groupId>
>>>>>> +            <groupId>jstl</groupId>
>>>>>>              <artifactId>jstl</artifactId>
>>>>>>          </dependency>
>>>>>>
>>>>>>
>>>>>> Modified: geronimo/server/trunk/configs/webconsole-tomcat/src/ 
>>>>>> plan/ plan.xml
>>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>>>>> configs/ webconsole-tomcat/src/plan/plan.xml?  
>>>>>> view=diff&rev=483773&r1=483772&r2=483773
>>>>>> =================================================================

>>>>>> ==== =========
>>>>>> --- geronimo/server/trunk/configs/webconsole-tomcat/src/plan/  
>>>>>> plan.xml (original)
>>>>>> +++ geronimo/server/trunk/configs/webconsole-tomcat/src/plan/  
>>>>>> plan.xml Thu Dec  7 17:53:34 2006
>>>>>> @@ -91,7 +91,7 @@
>>>>>>                      <type>jar</type>
>>>>>>                  </dependency>
>>>>>>                  <dependency>
>>>>>> -                    <groupId>javax.servlet</groupId>
>>>>>> +                    <groupId>jstl</groupId>
>>>>>>                      <artifactId>jstl</artifactId>
>>>>>>                      <type>jar</type>
>>>>>>                  </dependency>
>>>>>>
>>>>>> Modified: geronimo/server/trunk/pom.xml
>>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/ 
>>>>>> pom.xml? view=diff&rev=483773&r1=483772&r2=483773
>>>>>> =================================================================

>>>>>> ==== =========
>>>>>> --- geronimo/server/trunk/pom.xml (original)
>>>>>> +++ geronimo/server/trunk/pom.xml Thu Dec  7 17:53:34 2006
>>>>>> @@ -674,6 +674,12 @@
>>>>>>              </dependency>
>>>>>>
>>>>>>              <dependency>
>>>>>> +                <groupId>jstl</groupId>
>>>>>> +                <artifactId>jstl</artifactId>
>>>>>> +                <version>1.2</version>
>>>>>> +            </dependency>
>>>>>> +
>>>>>> +            <dependency>
>>>>>>                  <groupId>dwr</groupId>
>>>>>>                  <artifactId>dwr</artifactId>
>>>>>>                  <version>1.1.1</version>
>>>>>> @@ -1191,7 +1197,7 @@
>>>>>>                  <plugin>
>>>>>>                      <groupId>org.codehaus.mojo</groupId>
>>>>>>                      <artifactId>jspc-maven-plugin</artifactId>
>>>>>> -                    <version>1.4.6</version>
>>>>>> +                    <version>1.4.7-SNAPSHOT</version>
>>>>>>                      <executions>
>>>>>>                          <execution>
>>>>>>                              <id>jspc</id>
>>>>>> @@ -1373,6 +1379,11 @@
>>>>>>                specify where Genesis lives to pick it up +  
>>>>>> any  additional repositories.
>>>>>>          -->
>>>>>>
>>>>>> +        <repository>
>>>>>> +            <id>java.net</id>
>>>>>> +            <url>https://maven-repository.dev.java.net/nonav/
 
>>>>>> repository</url>
>>>>>> +            <layout>legacy</layout>
>>>>>> +        </repository>
>>>>>>          <repository>
>>>>>>              <id>apache-snapshots</id>
>>>>>>              <name>Apache Snapshots Repository</name>
>>>>>>
>>>>>>
>>>>>>
>>>>
>>>>
>>>>
>>>
>>>


Mime
View raw message