geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Blevins <david.blev...@visi.com>
Subject Re: svn commit: r487651 - /geronimo/server/trunk/pom.xml
Date Tue, 19 Dec 2006 20:23:17 GMT

On Dec 19, 2006, at 6:23 AM, Vamsavardhana Reddy wrote:

>
>
> On 12/16/06, Matt Hogstrom <matt@hogstrom.org> wrote:
> On Dec 15, 2006, at 3:57 PM, Jason Dillon wrote:
>
> > Yikes... what happened on this change?
> >
> > The diff shows a lot more changed than just what was indicated in
> > the comment...
> >
>
> Ya, looks like a formatting change.  A diff before would help :)  I
> too am guilty of transgressions like this.  Thanks for the reminder.
>
> I check the diff on each file before checkin and eliminate all  
> unnecessary changes (like line with spaces replacing blank lines  
> etc.).  It costs some extra time :o(, but, keeps the commit clean.   
> I hope that my energy will last for some more time :o)

I usually do as Jason suggested and check my "beauty" diff in first.   
That is if I notice the formatting is not right before I start  
editing :)

-David


Mime
View raw message