geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <david_jen...@yahoo.com>
Subject Re: versions in artifact ids (was: Re: svn commit: r483121 - in /geronimo/server/trunk: configs/client-system/pom.xml configs/jee-specs/pom.xml modules/ge-activemq-rar/pom.xml modules/geronimo-management/pom.xml modules/geronimo-tomcat/pom.xml pom.xml)
Date Wed, 06 Dec 2006 19:07:28 GMT
We discussed this pretty extensively when we adopted this naming  
scheme.  I still think the current scheme is the best choice.  My  
reasoning behind this is that for code that we control we should have  
a single version, such as 1.0, 1.1.2, 2.0, etc, but for code that is  
based on something we don't control such as specs, web containers,  
etc, something about the version of the external stuff should be  
reflected in the artifactId.  Thus specs should get the spec rev in  
the artifactId, and the web containers should get their version in  
the artifactid.  Thus the "jetty" modules and configs would be better  
named "jetty5".  The openejb configs should probably be "openejb2-*".

thanks
david jencks

On Dec 6, 2006, at 10:44 AM, Jason Dillon wrote:

> <opinion>
> I think it is really loopy that we have version information in  
> artifact ids.  A few people outside of the group have mentioned  
> this too me too.
>
> IMO it would be better if the artifact ids of the specs did not  
> have any version muck, and the version of that module was based on  
> the spec version + a revision number.
>
> So for example, the spec here would be:
>
> <groupId>org.apache.geronimo.specs</groupId>
> <artifactId>geronimo-j2ee-management</artifactId>
> <version>1.1-1</version>
>
> (or 1.1-1-SNAPSHOT for evil mvn snapshot muck)
>
> Anyways, I'm not going to do anything about this... but I will  
> continue to point out that putting version information into  
> artifactIds is a poor idea... and generally a bad one at that.
> </opinion>
>
> --jason
>
>
> On Dec 6, 2006, at 7:46 AM, akulshreshtha@apache.org wrote:
>
>> Author: akulshreshtha
>> Date: Wed Dec  6 07:46:42 2006
>> New Revision: 483121
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=483121
>> Log:
>> GERONIMO-2629 Upgrade to J2EE Management 1.1
>>
>> Modified:
>>     geronimo/server/trunk/configs/client-system/pom.xml
>>     geronimo/server/trunk/configs/jee-specs/pom.xml
>>     geronimo/server/trunk/modules/ge-activemq-rar/pom.xml
>>     geronimo/server/trunk/modules/geronimo-management/pom.xml
>>     geronimo/server/trunk/modules/geronimo-tomcat/pom.xml
>>     geronimo/server/trunk/pom.xml
>>
>> Modified: geronimo/server/trunk/configs/client-system/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/configs/ 
>> client-system/pom.xml?view=diff&rev=483121&r1=483120&r2=483121
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/configs/client-system/pom.xml (original)
>> +++ geronimo/server/trunk/configs/client-system/pom.xml Wed Dec  6  
>> 07:46:42 2006
>> @@ -44,7 +44,7 @@
>>
>>          <dependency>
>>              <groupId>org.apache.geronimo.specs</groupId>
>> -            <artifactId>geronimo-j2ee-management_1.0_spec</ 
>> artifactId>
>> +            <artifactId>geronimo-j2ee-management_1.1_spec</ 
>> artifactId>
>>          </dependency>
>>
>>      </dependencies>
>>
>> Modified: geronimo/server/trunk/configs/jee-specs/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/configs/ 
>> jee-specs/pom.xml?view=diff&rev=483121&r1=483120&r2=483121
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/configs/jee-specs/pom.xml (original)
>> +++ geronimo/server/trunk/configs/jee-specs/pom.xml Wed Dec  6  
>> 07:46:42 2006
>> @@ -58,7 +58,7 @@
>>
>>          <dependency>
>>              <groupId>org.apache.geronimo.specs</groupId>
>> -            <artifactId>geronimo-j2ee-management_1.0_spec</ 
>> artifactId>
>> +            <artifactId>geronimo-j2ee-management_1.1_spec</ 
>> artifactId>
>>          </dependency>
>>
>>          <dependency>
>>
>> Modified: geronimo/server/trunk/modules/ge-activemq-rar/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ge- 
>> activemq-rar/pom.xml?view=diff&rev=483121&r1=483120&r2=483121
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/modules/ge-activemq-rar/pom.xml (original)
>> +++ geronimo/server/trunk/modules/ge-activemq-rar/pom.xml Wed Dec   
>> 6 07:46:42 2006
>> @@ -120,7 +120,7 @@
>>
>>                  <exclusion>
>>                      <groupId>org.apache.geronimo.specs</groupId>
>> -                    <artifactId>geronimo-j2ee- 
>> management_1.0_spec</artifactId>
>> +                    <artifactId>geronimo-j2ee- 
>> management_1.1_spec</artifactId>
>>                  </exclusion>
>>
>>                  <exclusion>
>>
>> Modified: geronimo/server/trunk/modules/geronimo-management/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
>> geronimo-management/pom.xml?view=diff&rev=483121&r1=483120&r2=483121
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/modules/geronimo-management/pom.xml  
>> (original)
>> +++ geronimo/server/trunk/modules/geronimo-management/pom.xml Wed  
>> Dec  6 07:46:42 2006
>> @@ -46,7 +46,7 @@
>>
>>          <dependency>
>>              <groupId>org.apache.geronimo.specs</groupId>
>> -            <artifactId>geronimo-j2ee-management_1.0_spec</ 
>> artifactId>
>> +            <artifactId>geronimo-j2ee-management_1.1_spec</ 
>> artifactId>
>>          </dependency>
>>
>>      </dependencies>
>>
>> Modified: geronimo/server/trunk/modules/geronimo-tomcat/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
>> geronimo-tomcat/pom.xml?view=diff&rev=483121&r1=483120&r2=483121
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/modules/geronimo-tomcat/pom.xml (original)
>> +++ geronimo/server/trunk/modules/geronimo-tomcat/pom.xml Wed Dec   
>> 6 07:46:42 2006
>> @@ -54,7 +54,7 @@
>>
>>          <dependency>
>>              <groupId>org.apache.geronimo.specs</groupId>
>> -            <artifactId>geronimo-j2ee-management_1.0_spec</ 
>> artifactId>
>> +            <artifactId>geronimo-j2ee-management_1.1_spec</ 
>> artifactId>
>>              <scope>provided</scope>
>>          </dependency>
>>
>>
>> Modified: geronimo/server/trunk/pom.xml
>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml? 
>> view=diff&rev=483121&r1=483120&r2=483121
>> ===================================================================== 
>> =========
>> --- geronimo/server/trunk/pom.xml (original)
>> +++ geronimo/server/trunk/pom.xml Wed Dec  6 07:46:42 2006
>> @@ -135,8 +135,8 @@
>>
>>              <dependency>
>>                  <groupId>org.apache.geronimo.specs</groupId>
>> -                <artifactId>geronimo-j2ee-management_1.0_spec</ 
>> artifactId>
>> -                <version>1.0.1</version>
>> +                <artifactId>geronimo-j2ee-management_1.1_spec</ 
>> artifactId>
>> +                <version>1.0-SNAPSHOT</version>
>>              </dependency>
>>
>>              <dependency>
>>
>>
>


Mime
View raw message