Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 68262 invoked from network); 8 Nov 2006 04:43:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Nov 2006 04:43:05 -0000 Received: (qmail 70911 invoked by uid 500); 8 Nov 2006 04:43:14 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 70862 invoked by uid 500); 8 Nov 2006 04:43:14 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 70850 invoked by uid 99); 8 Nov 2006 04:43:14 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2006 20:43:14 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of goyathlay.geronimo@gmail.com designates 66.249.82.227 as permitted sender) Received: from [66.249.82.227] (HELO wx-out-0506.google.com) (66.249.82.227) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Nov 2006 20:42:59 -0800 Received: by wx-out-0506.google.com with SMTP id i27so1505377wxd for ; Tue, 07 Nov 2006 20:42:39 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XIu1f34P7a38f5uBpB47QfepNS9Dv9TmUXNfy1ZqKwYi6clLh7NqRuBjd2ckVf7JWqh9jad9qjoeVYak+Rrb0fSeF+RDWFw1ILNcn+h69ptWX84H52/cyIfO51Zq7DIMEWBCXp7ODRivP8lmjifuHQzLvYiODcx+8F4kR3+sPYc= Received: by 10.90.94.2 with SMTP id r2mr2777234agb.1162960958887; Tue, 07 Nov 2006 20:42:38 -0800 (PST) Received: by 10.90.94.18 with HTTP; Tue, 7 Nov 2006 20:42:38 -0800 (PST) Message-ID: Date: Tue, 7 Nov 2006 23:42:38 -0500 From: "Prasad Kashyap" To: dev@geronimo.apache.org Subject: Re: svn commit: r472156 - in /geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/mavenplugins/geronimo: module/ server/ In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061107163935.13F611A9846@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Good catch. OK. Will rename. Cheers Prasad On 11/7/06, Jason Dillon wrote: > If getGoalName() is going to return a class name, then I suggest that > getGoalName() be removed or renamed... as these are no longer what I > would expect a call to getGoalName() to return. > > --jason > > > On Nov 7, 2006, at 8:39 AM, prasad@apache.org wrote: > > > Author: prasad > > Date: Tue Nov 7 08:39:33 2006 > > New Revision: 472156 > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=472156 > > Log: > > * getGoalName had hardcoded strings in them (mojo names) > > * changed them to return the packageName + className > > * surefire reporting needs the package name. > > > > Modified: > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > DeployModuleMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > ListModulesMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StartModuleMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StopModuleMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > UndeployModuleMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > InstallAssemblyMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StartServerMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StopServerMojo.java > > geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > WaitForServerMojo.java > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > DeployModuleMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/module/DeployModuleMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > DeployModuleMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > DeployModuleMojo.java Tue Nov 7 08:39:33 2006 > > @@ -158,9 +158,6 @@ > > } > > > > protected String getGoalName() { > > - // > > - // FIXME: There has to be way this can be computed instead > > of hardcoded absolutely. > > - // > > - return "deploy-module"; > > - } > > + return this.getClass().getName(); > > + } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > ListModulesMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/module/ListModulesMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > ListModulesMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > ListModulesMojo.java Tue Nov 7 08:39:33 2006 > > @@ -51,6 +51,6 @@ > > } > > > > protected String getGoalName() { > > - return "list-modules"; > > + return this.getClass().getName(); > > } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StartModuleMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/module/StartModuleMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StartModuleMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StartModuleMojo.java Tue Nov 7 08:39:33 2006 > > @@ -38,9 +38,6 @@ > > } > > > > protected String getGoalName() { > > - // > > - // FIXME: There has to be way this can be computed instead > > of hardcoded absolutely. > > - // > > - return "start-module"; > > - } > > + return this.getClass().getName(); > > + } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StopModuleMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/module/StopModuleMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StopModuleMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > StopModuleMojo.java Tue Nov 7 08:39:33 2006 > > @@ -38,9 +38,6 @@ > > } > > > > protected String getGoalName() { > > - // > > - // FIXME: There has to be way this can be computed instead > > of hardcoded absolutely. > > - // > > - return "stop-module"; > > + return this.getClass().getName(); > > } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > UndeployModuleMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/module/UndeployModuleMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > UndeployModuleMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/module/ > > UndeployModuleMojo.java Tue Nov 7 08:39:33 2006 > > @@ -38,9 +38,6 @@ > > } > > > > protected String getGoalName() { > > - // > > - // FIXME: There has to be way this can be computed instead > > of hardcoded absolutely. > > - // > > - return "undeploy-module"; > > - } > > + return this.getClass().getName(); > > + } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > InstallAssemblyMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/server/InstallAssemblyMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > InstallAssemblyMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > InstallAssemblyMojo.java Tue Nov 7 08:39:33 2006 > > @@ -34,6 +34,6 @@ > > } > > > > protected String getGoalName() { > > - return "install-assembly"; > > - } > > + return this.getClass().getName(); > > + } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StartServerMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/server/StartServerMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StartServerMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StartServerMojo.java Tue Nov 7 08:39:33 2006 > > @@ -360,10 +360,6 @@ > > } > > > > protected String getGoalName() { > > - // > > - // FIXME: There has to be way this can be computed instead > > of hardcoded absolutely. > > - // > > - > > - return "start-server"; > > - } > > + return this.getClass().getName(); > > + } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StopServerMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/server/StopServerMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StopServerMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > StopServerMojo.java Tue Nov 7 08:39:33 2006 > > @@ -56,6 +56,6 @@ > > } > > > > protected String getGoalName() { > > - return "stop-server"; > > - } > > + return this.getClass().getName(); > > + } > > } > > > > Modified: geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/ > > src/main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > WaitForServerMojo.java > > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/maven- > > plugins/geronimo-maven-plugin/src/main/java/org/apache/geronimo/ > > mavenplugins/geronimo/server/WaitForServerMojo.java? > > view=diff&rev=472156&r1=472155&r2=472156 > > ====================================================================== > > ======== > > --- geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > WaitForServerMojo.java (original) > > +++ geronimo/server/trunk/maven-plugins/geronimo-maven-plugin/src/ > > main/java/org/apache/geronimo/mavenplugins/geronimo/server/ > > WaitForServerMojo.java Tue Nov 7 08:39:33 2006 > > @@ -94,9 +94,6 @@ > > } > > > > protected String getGoalName() { > > - // > > - //FIXME: There has to be way this can be computed instead > > of hardcoded absolutely. > > - // > > - return "wait-for-server"; > > - } > > + return this.getClass().getName(); > > + } > > } > > > > > >