Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 34851 invoked from network); 4 Nov 2006 21:32:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Nov 2006 21:32:01 -0000 Received: (qmail 13133 invoked by uid 500); 4 Nov 2006 21:32:11 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 13083 invoked by uid 500); 4 Nov 2006 21:32:10 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 13072 invoked by uid 99); 4 Nov 2006 21:32:10 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Nov 2006 13:32:10 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of goyathlay.geronimo@gmail.com designates 64.233.182.187 as permitted sender) Received: from [64.233.182.187] (HELO nf-out-0910.google.com) (64.233.182.187) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Nov 2006 13:31:58 -0800 Received: by nf-out-0910.google.com with SMTP id l36so2363805nfa for ; Sat, 04 Nov 2006 13:31:37 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=j/0tq2xmlLadd2JNTqQ7B+hku819d8/FyNGssdSvxnJoC/JqV7HDcRT1wYtadzsJrZzXKeeYVneWm9LKeLP6S7fvGVfdenwhfVd972skJbof69FdEJgChyGwEMIq1SaMwJxZCg3lK54501LfGI7/b06bJujUVwPVmCqZE1dYTPY= Received: by 10.82.105.13 with SMTP id d13mr1050897buc.1162675897068; Sat, 04 Nov 2006 13:31:37 -0800 (PST) Received: by 10.82.112.14 with HTTP; Sat, 4 Nov 2006 13:31:36 -0800 (PST) Message-ID: Date: Sat, 4 Nov 2006 16:31:36 -0500 From: "Prasad Kashyap" To: dev@geronimo.apache.org Subject: Re: [discussion] openejb-itests in testsuite In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <50A5BD06-96A7-4993-A4B1-9A8EF9028FAC@visi.com> <32386304-C262-4B26-B18E-F84E265F7B6D@visi.com> <27B19F01-B5CD-46C6-A2E0-8D798A3B1E32@visi.com> X-Virus-Checked: Checked by ClamAV on apache.org David, Can you please review and apply the patch here - https://issues.apache.org/jira/browse/OPENEJB-302 Thanx Prasad On 11/3/06, David Blevins wrote: > > On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote: > > > OK. Sounds good. "o.a.openejb" it would be. > > > > The reasons I want to leave the tests in one single module are > > manifold. > > > > 1) That is how they are today. > > 2) To split them, it would have to be someone from openejb. I have no > > idea how they are structured. > > 3) My top priority now is to get the testsuite framework integrated > > with the G build. > > That's fine. We can do that part later. > > -David > > > > Cheers > > Prasad > > > > On 11/1/06, David Blevins wrote: > >> > >> On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote: > >> > >> > On 10/30/06, David Blevins wrote: > >> >> > >> >> On Oct 30, 2006, at 7:51 AM, Prasad Kashyap wrote: > >> >> > >> >> > Thanx. Please see comments inline - > >> >> > > >> > > >> >> >> Couple thoughts on the poms: > >> >> >> > >> >> >> - the parent would lineage would be > >> >> org.apache.openejb:itests -> > >> >> >> org.apache.openejb:openejb > >> >> >> - the groupId would be org.apache.openejb > >> >> > > >> >> > The groupId and the parent lineage looks good. As stated above, > >> >> there > >> >> > would be many child modules for the beans under the itests > >> parent > >> >> > module > >> >> > > >> >> > groupId: o.a.openejb > >> >> > openejb -> itests -> itests-security-xxx > >> >> > openejb -> itests -> itests-cmp2-xxx > >> >> > >> >> Exactly. > >> >> > >> > > >> > After having built the itest beans as per our discussion above, the > >> > contents of the openejb directory in m2 local repo are - > >> > ${settings.localRepository}/org/apache/openejb/ > >> > > >> > itests-cmp2-cmrmapping > >> > itests-cmp2-petstore > >> > itests-cmp2-prefetch > >> > itests-cmp2-storage > >> > itests-itests-core > >> > itests-security-001 > >> > itests-security-002 > >> > itests-security-003 > >> > openejb > >> > openejb-builder > >> > openejb-corba > >> > openejb-corba-builder > >> > openejb-core > >> > openejb-itests > >> > openejb-pkgen-builder > >> > openejb-sunorb > >> > openejb-yoko > >> > > >> > Does this look good ? Or should we move the itests artifacts one > >> > level down to groupId "o.a.openejb.itests" ? > >> > >> Let's keep it in o.a.openejb for now as that's the way it is in 3.x. > >> > >> > For now, I shall put all the tests into 1 artifact module. We > >> should > >> > look at breaking them and putting them with their respective bean > >> > modules later on. > >> > >> What's the issue with doing that now? > >> > >> -David > >> > >> > > > >