Return-Path: 
 <dev-return-41165-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 86786 invoked from network); 11 Nov 2006 22:51:27 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 11 Nov 2006 22:51:27 -0000
Received: (qmail 8214 invoked by uid 500); 11 Nov 2006 22:51:36 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 7981 invoked by uid 500); 11 Nov 2006 22:51:34 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 7970 invoked by uid 99); 11 Nov 2006 22:51:34 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Nov 2006 14:51:34 -0800
X-ASF-Spam-Status: No, hits=2.0 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: domain of nathan.mittler@gmail.com
 designates 64.233.166.181 as permitted sender)
Received: from [64.233.166.181] (HELO py-out-1112.google.com) (64.233.166.181)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Nov 2006 14:51:20 -0800
Received: by py-out-1112.google.com with SMTP id f31so466900pyh
        for <dev@geronimo.apache.org>; Sat, 11 Nov 2006 14:50:27 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:mime-version:content-type;
        b=buUzFi5dfVWw07XTtRtfBNvBfywjtE0dAzOo+L60hAX7H8K7yMMLEmNMtahJKg4gynqM/q85XSM+Q5l1BiwQKW2SSC51SUNEom0cIzwwfknn09KyZYH1lsV7YEza/I9znbuHBzePOD7J7d38EcGZH/8ZoFupCB0VZAdda4rwnOY=
Received: by 10.35.97.17 with SMTP id z17mr6631375pyl.1163284823019;
        Sat, 11 Nov 2006 14:40:23 -0800 (PST)
Received: by 10.35.15.20 with HTTP; Sat, 11 Nov 2006 14:40:22 -0800 (PST)
Message-ID: <8a6feb940611111440s3664ce9cl371ac9b5371e7d64@mail.gmail.com>
Date: Sat, 11 Nov 2006 17:40:22 -0500
From: "Nathan Mittler" <nathan.mittler@gmail.com>
To: dev@geronimo.apache.org
Subject: code review for transport patch
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_7363_9233998.1163284822892"
X-Virus-Checked: Checked by ClamAV on apache.org

------=_Part_7363_9233998.1163284822892
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hey guys,
I took a crack at a fix which sends a stomp error frame back to the client
in the event of a failure during authentication or authorization.  I haven't
been through much of this code before, so I'd like to get some feedback on
my changes.

Part of my concern is that some of the tweaks will affect all protocols (not
only stomp) so I want to make sure I get it right.  In particular, a
connection error is returned back to the client if an exception is caught by
the TransportConnection.onCommand.  In the case of stomp, this ends up as a
stomp error frame.

Here's the patch against the latest trunk:

http://people.apache.org/~nmittler/patch.txt

I also have a tarball if anyone wants to check it out:

http://people.apache.org/~nmittler/
apache-activemq-4.2-incubator-SNAPSHOT.tar.gz<http://people.apache.org/%7Enmittler/apache-activemq-4.2-incubator-SNAPSHOT.tar.gz>

Thanks,
Nate

------=_Part_7363_9233998.1163284822892
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hey guys,<br>
I took a crack at a fix which sends a stomp error frame back to the
client in the event of a failure during authentication or
authorization.&nbsp; I haven't been through much of this code before,
so I'd like to get some feedback on my changes.<br>
<br>
Part of my concern is that some of the tweaks will affect all protocols
(not only stomp) so I want to make sure I get it right.&nbsp; In
particular, a connection error is returned back to the client if an
exception is caught by the TransportConnection.onCommand.&nbsp; In the
case of stomp, this ends up as a stomp error frame.<br>
<br>
Here's the patch against the latest trunk:<br>
<br>
<a href="http://people.apache.org/~nmittler/patch.txt">http://people.apache.org/~nmittler/patch.txt</a><br>
<br>
I also have a tarball if anyone wants to check it out:<br>
<br>
<a href="http://people.apache.org/~nmittler/">http://people.apache.org/~nmittler/</a><a href="http://people.apache.org/%7Enmittler/apache-activemq-4.2-incubator-SNAPSHOT.tar.gz">apache-activemq-4.2-incubator-SNAPSHOT.tar.gz
</a><br>
<br>
Thanks,<br>
Nate<br>

------=_Part_7363_9233998.1163284822892--