Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 70648 invoked from network); 6 Nov 2006 17:15:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Nov 2006 17:15:36 -0000 Received: (qmail 40881 invoked by uid 500); 6 Nov 2006 17:15:44 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 40825 invoked by uid 500); 6 Nov 2006 17:15:43 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 40814 invoked by uid 99); 6 Nov 2006 17:15:43 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Nov 2006 09:15:43 -0800 X-ASF-Spam-Status: No, hits=3.2 required=10.0 tests=HTML_MESSAGE,RCVD_IN_SORBS_WEB,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of sppatel@gmail.com designates 64.233.182.184 as permitted sender) Received: from [64.233.182.184] (HELO nf-out-0910.google.com) (64.233.182.184) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Nov 2006 09:15:28 -0800 Received: by nf-out-0910.google.com with SMTP id c29so2422324nfb for ; Mon, 06 Nov 2006 09:15:07 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:mime-version:in-reply-to:references:content-type:message-id:from:subject:date:to:x-mailer:sender; b=dc/qs98ArQiXpdCtIH7Lyh4qTeBJbHrNFujlHznA4SUQbSuJw6DujwF2I85aC3m6NTxjMdvGLW0W+iUnY6g16hVAzKonHikJ6SEfbEemOY9L8d4nqMgqYqFKsSVZ6pJmwBBw3LvE/vUo9ShAYn5xRA3qjUbdj82Yh8aNXFh8szI= Received: by 10.48.202.19 with SMTP id z19mr883787nff.1162833306244; Mon, 06 Nov 2006 09:15:06 -0800 (PST) Received: from ?9.37.214.135? ( [129.33.49.251]) by mx.google.com with ESMTP id 66sm5813250wra.2006.11.06.09.15.05; Mon, 06 Nov 2006 09:15:05 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <40966E49-EE14-42A4-B76F-BB65009881CB@gmail.com> References: <0F70D6F0-A745-4C23-AEAE-126A4320E5FE@gmail.com> <487D9203-9C22-4134-9C46-700303A00407@gmail.com> <40966E49-EE14-42A4-B76F-BB65009881CB@gmail.com> Content-Type: multipart/alternative; boundary=Apple-Mail-15--157479761 Message-Id: <6EFCEBC4-25CA-4114-8C68-D7DA09289DAA@gmail.com> From: Sachin Patel Subject: Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2) Date: Mon, 6 Nov 2006 12:15:13 -0500 To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.752.3) Sender: Sachin Patel X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-15--157479761 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Actually since you have it up, can you go ahead and fix it? On Nov 6, 2006, at 12:02 PM, Kevan Miller wrote: > > On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote: > >> Ok. Fair enough. Please revote on.. >> >> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse- >> plugin-1.2.0-v200611060915-deployable-RC2.zip >> >> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST. >> > > Sachin, > G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since > you are including geronimo-util, they should be added to the your > notice and license files, also. I don't know of a way to > automatically aggregate this LICENSE and NOTICE information, but it > would sure be nice... > > Minor, but it looks like NOTICE has a mix of DOS and UNIX line > endings. > > I tried out rat (release audit tool) from http://code.google.com/p/ > arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime > this week. > > It identified that the following source files were missing > appropriate headers. Are .classpath, .project, and .option files > really meant to be under svn control? There were 3 obvious source > files that are missing headers... > > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.common.deployment.model/.classpath) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.common.deployment.model/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.common.deployment.model.edit/.classpath) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.common.deployment.model.edit/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.deployment.model/.classpath) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.deployment.model/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.deployment.model.edit/.classpath) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.deployment.model.edit/.project) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.runtime.common/.project) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.runtime.v1/.project) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.runtime.v11/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.core/.classpath) > ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.core/.options) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.core/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.ui/.classpath) > ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.ui/.options) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.ui/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v1.core/.classpath) > ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v1.core/.options) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v1.core/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v1.ui/.classpath) > ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v1.ui/.options) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v1.ui/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v11.core/.classpath) > ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v11.core/.options) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v11.core/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v11.ui/.classpath) > ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v11.ui/.options) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.st.v11.ui/.project) > ==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/ > trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/ > st/v11/ui/Activator.java) > ==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/ > trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/ > st/v11/ui/internal/Messages.java) > ==SecurityPage.java (/Users/kevan/geronimo/devtools/eclipse-plugin/ > trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/ > st/v11/ui/pages/SecurityPage.java) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.v11.deployment.model/.classpath) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.v11.deployment.model/.project) > ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.v11.deployment.model.edit/.classpath) > ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ > plugins/org.apache.geronimo.v11.deployment.model.edit/.project) > > I'm + 1 once the Bouncy Castle and source header issues are resolved. > > --kevan -sachin --Apple-Mail-15--157479761 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1 Actually since you have it up, = can you go ahead and fix it?

On Nov 6, 2006, at 12:02 = PM, Kevan Miller wrote:


On Nov 6, 2006, at 10:16 AM, Sachin Patel = wrote:

Ok.=A0 Fair enough.=A0 Please revote on..


Vote will concluded in 72 = hours on Nov 9, 10:00 AM EST.


Sachin= ,
G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. = Since you are including geronimo-util, they should be added to the your = notice and license files, also. I don't know of a way to automatically = aggregate this LICENSE and NOTICE information, but it would sure be = nice...

Minor, = but it looks like NOTICE has a mix of DOS and UNIX line = endings.

I = tried out rat (release audit tool) from=A0http://code.google.com/p/arat/= Seems pretty useful. I'll point it at Geronimo 1.2, sometime this = week.

It = identified that the following source files were missing appropriate = headers. Are .classpath, .project, and .option files really meant to be = under svn control? There were 3 obvious source files that are missing = headers...

=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.common.deployment.model/.classpath)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.common.deployment.model/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.common.deployment.model.edit/.classpath)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.common.deployment.model.edit/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.deployment.model/.classpath)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.deployment.model/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.deployment.model.edit/.classpath)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.deployment.model.edit/.project)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.runtime.common/.project)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.runtime.v1/.project)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.runtime.v11/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.core/.classpath)
=3D=3D.options = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.core/.options)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.core/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.ui/.classpath)
=3D=3D.options = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.ui/.options)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.ui/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v1.core/.classpath)
=3D=3D.options = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v1.core/.options)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v1.core/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v1.ui/.classpath)
=3D=3D.options = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v1.ui/.options)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v1.ui/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.core/.classpath)
=3D=3D.options = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.core/.options)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.core/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.ui/.classpath)
=3D=3D.options = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.ui/.options)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.ui/.project)
=3D=3DActivator.java = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/Activator.java)
=3D=3DMessages.java = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/internal/Messages.java)=
=3D=3DSecurityPage.java = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.st.v11.ui/src/org/apache/geronimo/st/v11/ui/pages/SecurityPage.java= )
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.v11.deployment.model/.classpath)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.v11.deployment.model/.project)
=3D=3D.classpath = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.v11.deployment.model.edit/.classpath)
=3D=3D.project = (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.ge= ronimo.v11.deployment.model.edit/.project)

I'm + 1 once the Bouncy = Castle and source header issues are resolved.

--kevan


 =

= --Apple-Mail-15--157479761--