geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sachin Patel <sppat...@gmail.com>
Subject Re: [VOTE] Release Eclipse Plugin 1.2.0 (RC2)
Date Mon, 06 Nov 2006 17:15:13 GMT
Actually since you have it up, can you go ahead and fix it?

On Nov 6, 2006, at 12:02 PM, Kevan Miller wrote:

>
> On Nov 6, 2006, at 10:16 AM, Sachin Patel wrote:
>
>> Ok.  Fair enough.  Please revote on..
>>
>> http://people.apache.org/dist/geronimo/eclipse/unstable/g-eclipse- 
>> plugin-1.2.0-v200611060915-deployable-RC2.zip
>>
>> Vote will concluded in 72 hours on Nov 9, 10:00 AM EST.
>>
>
> Sachin,
> G 1.1.1 added Bouncy Castle to the LICENSE and NOTICE files. Since  
> you are including geronimo-util, they should be added to the your  
> notice and license files, also. I don't know of a way to  
> automatically aggregate this LICENSE and NOTICE information, but it  
> would sure be nice...
>
> Minor, but it looks like NOTICE has a mix of DOS and UNIX line  
> endings.
>
> I tried out rat (release audit tool) from http://code.google.com/p/ 
> arat/ Seems pretty useful. I'll point it at Geronimo 1.2, sometime  
> this week.
>
> It identified that the following source files were missing  
> appropriate headers. Are .classpath, .project, and .option files  
> really meant to be under svn control? There were 3 obvious source  
> files that are missing headers...
>
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.common.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.common.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.common.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.common.deployment.model.edit/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.deployment.model.edit/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.runtime.common/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.runtime.v1/.project)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.runtime.v11/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.ui/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v1.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v1.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v1.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v1.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v1.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v1.ui/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v11.core/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v11.core/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v11.core/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v11.ui/.classpath)
> ==.options (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v11.ui/.options)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.st.v11.ui/.project)
> ==Activator.java (/Users/kevan/geronimo/devtools/eclipse-plugin/ 
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/ 
> st/v11/ui/Activator.java)
> ==Messages.java (/Users/kevan/geronimo/devtools/eclipse-plugin/ 
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/ 
> st/v11/ui/internal/Messages.java)
> ==SecurityPage.java (/Users/kevan/geronimo/devtools/eclipse-plugin/ 
> trunk/plugins/org.apache.geronimo.st.v11.ui/src/org/apache/geronimo/ 
> st/v11/ui/pages/SecurityPage.java)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.v11.deployment.model/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.v11.deployment.model/.project)
> ==.classpath (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.v11.deployment.model.edit/.classpath)
> ==.project (/Users/kevan/geronimo/devtools/eclipse-plugin/trunk/ 
> plugins/org.apache.geronimo.v11.deployment.model.edit/.project)
>
> I'm + 1 once the Bouncy Castle and source header issues are resolved.
>
> --kevan


-sachin



Mime
View raw message