geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: svn commit: r470013 - /geronimo/server/trunk/modules/geronimo-system/src/test/java/org/apache/geronimo/system/properties/NamingPropertiesTest.java
Date Thu, 02 Nov 2006 05:37:35 GMT
Ya, this looks bogus...

--jason


On Nov 1, 2006, at 3:17 PM, Jacek Laskowski wrote:

> On 11/1/06, rickmcguire@apache.org <rickmcguire@apache.org> wrote:
>> Author: rickmcguire
>> Date: Wed Nov  1 09:48:44 2006
>> New Revision: 470013
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=470013
>> Log:
>> GERONIMO-1840 NamingPropertiesTest is not compatible with non-Sun  
>> VMs.
> ...
>> +        try {
>> +            // the above assumes we're running on a Sun JVM.  If  
>> we can't load the class first,
>> +            // we'll skip the attempt at creating the  
>> InitialContext.  We've already verified that the
>> +            // system properties have been set to the correct  
>> values, so this last bit is largely a formality.
>> +            Class.forName("NAME_FACTORY_INITIAL");
>> +            new InitialContext();
>> +        } catch (ClassNotFoundException e) {
>> +        }
>
> It's not the first time I ask for some help understanding a change and
> this one is not an exception.
>
> Why do we look up the "NAME_FACTORY_INITIAL" class since it's deemed
> to fail every time?
>
> Jacek
>
> -- 
> Jacek Laskowski
> http://www.jaceklaskowski.pl


Mime
View raw message