geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Blevins <david.blev...@visi.com>
Subject Re: [discussion] openejb-itests in testsuite
Date Tue, 21 Nov 2006 19:21:06 GMT

On Nov 21, 2006, at 11:08 AM, Prasad Kashyap wrote:

> David,
>
> Can you please apply this patch as well.
>
> * It reorders the execution of itests and modules.
> * it configures the whole jar plugin to skip adding maven artifacts.

I applied what you described on IRC, let me know if that's not right.

> Thanx
> prasad
>
> On 11/20/06, Prasad Kashyap <goyathlay.geronimo@gmail.com> wrote:
>> https://issues.apache.org/jira/browse/OPENEJB-305 is ready.
>>
>> The java files from the OPENEJB-302 patch were not applied. Hence the
>> plans kept failing.
>>
>> I have the same changes in the above patches too. Please apply them.
>>
>> I have merged the cmp2 plans with itests-core.
>>
>> Without the prefetch plan, the other 3 cmp2 plans when merged with
>> itests-core deploy and starts succeessfully
>>
>> There is a problem with prefetch plan. After merging it, the jar  
>> fails
>> to start. See log in JIRA. Help needed here please !
>>
>> Caused by: org.tranql.ql.QueryException: Finder [Finder
>> method=[findPrefetchAll]; EJB-QL=[
>>                     SELECT OBJECT(o) FROM Order AS o WHERE o.id = ?1
>>                 ]]
>>         at org.tranql.sql.EJBQLToPhysicalQuery.buildFinder 
>> (EJBQLToPhysicalQuery.java:143)
>>         at org.tranql.sql.EJBQLToPhysicalQuery.buildFinders 
>> (EJBQLToPhysicalQuery.java:90)
>>         ... 86 more
>> Caused by: org.tranql.ql.QueryException: Finder does not return the
>> right abstract schema type.
>>         at org.tranql.sql.EJBQLToPhysicalQuery.buildFinder 
>> (EJBQLToPhysicalQuery.java:137)
>>         ... 87 more
>>
>>
>>
>> Thanx
>> Prasad
>>
>> On 11/16/06, David Blevins <david.blevins@visi.com> wrote:
>> >
>> > On Nov 14, 2006, at 8:47 AM, Prasad Kashyap wrote:
>> >
>> > > I began by "migrating" just the itests-core DDs and then  
>> deployed it.
>> > > It distributed the artifact but failed to start it.
>> > >
>> > > I hit the following error.
>> > > http://rifers.org/paste/show/2308
>> > >
>> > > Can you please decipher this "unknown reason" error for me ?  
>> These DDs
>> > > worked fine when I submitted the patch earlier. The only small  
>> diff
>> > > between the DD then and now is the adjustment for the modified  
>> pkg
>> > > structure (o.a.openejb)
>> > >
>> > > The patch for the migrated DD is attached here.
>> > >
>> >
>> > Hmm, unfortunately I don't know what the "unknown reason" is
>> > either..  Is there something in your logs that has more detail?
>> > (hoping that what was posted wasn't the logs :)
>> >
>> > -David
>> >
>> >
>> > > Thanx
>> > > Prasad
>> > >
>> > >
>> > > On 11/13/06, Prasad Kashyap <goyathlay.geronimo@gmail.com> wrote:
>> > >> Thanks for these comments, David.
>> > >>
>> > >> https://issues.apache.org/jira/browse/ 
>> OPENEJB-302#action_12448245
>> > >>
>> > >> I'll create an ejbcontainer-testsuite now.
>> > >>
>> > >> Thanx
>> > >> Prasad
>> > >>
>> > >> On 11/4/06, Prasad Kashyap <goyathlay.geronimo@gmail.com> wrote:
>> > >> > David,
>> > >> >
>> > >> > Can you please review and apply the patch here -
>> > >> > https://issues.apache.org/jira/browse/OPENEJB-302
>> > >> >
>> > >> > Thanx
>> > >> > Prasad
>> > >> >
>> > >> > On 11/3/06, David Blevins <david.blevins@visi.com> wrote:
>> > >> > >
>> > >> > > On Nov 2, 2006, at 6:30 PM, Prasad Kashyap wrote:
>> > >> > >
>> > >> > > > OK. Sounds good. "o.a.openejb" it would be.
>> > >> > > >
>> > >> > > > The reasons I want to leave the tests in one single
 
>> module are
>> > >> > > > manifold.
>> > >> > > >
>> > >> > > > 1) That is how they are today.
>> > >> > > > 2) To split them, it would have to be someone from 

>> openejb.
>> > >> I have no
>> > >> > > > idea how they are structured.
>> > >> > > > 3) My top priority now is to get the testsuite framework
>> > >> integrated
>> > >> > > > with the G build.
>> > >> > >
>> > >> > > That's fine.  We can do that part later.
>> > >> > >
>> > >> > > -David
>> > >> > >
>> > >> > >
>> > >> > > > Cheers
>> > >> > > > Prasad
>> > >> > > >
>> > >> > > > On 11/1/06, David Blevins <david.blevins@visi.com>
wrote:
>> > >> > > >>
>> > >> > > >> On Oct 31, 2006, at 10:07 AM, Prasad Kashyap wrote:
>> > >> > > >>
>> > >> > > >> > On 10/30/06, David Blevins <david.blevins@visi.com>
 
>> wrote:
>> > >> > > >> >>
>> > >> > > >> >> On Oct 30, 2006, at 7:51 AM, Prasad Kashyap
wrote:
>> > >> > > >> >>
>> > >> > > >> >> > Thanx. Please see comments inline
-
>> > >> > > >> >> >
>> > >> > > >> >
>> > >> > > >> >> >> Couple thoughts on the poms:
>> > >> > > >> >> >>
>> > >> > > >> >> >>    - the parent would lineage
would be
>> > >> > > >> >> org.apache.openejb:itests ->
>> > >> > > >> >> >> org.apache.openejb:openejb
>> > >> > > >> >> >>    - the groupId would be org.apache.openejb
>> > >> > > >> >> >
>> > >> > > >> >> > The groupId and the parent lineage
looks good. As
>> > >> stated above,
>> > >> > > >> >> there
>> > >> > > >> >> > would be many child modules for the
beans under the
>> > >> itests
>> > >> > > >> parent
>> > >> > > >> >> > module
>> > >> > > >> >> >
>> > >> > > >> >> > groupId: o.a.openejb
>> > >> > > >> >> > openejb -> itests -> itests-security-xxx
>> > >> > > >> >> > openejb -> itests -> itests-cmp2-xxx
>> > >> > > >> >>
>> > >> > > >> >> Exactly.
>> > >> > > >> >>
>> > >> > > >> >
>> > >> > > >> > After having built the itest beans as per our
 
>> discussion
>> > >> above, the
>> > >> > > >> > contents of the openejb directory in m2 local
repo   
>> are -
>> > >> > > >> > ${settings.localRepository}/org/apache/openejb/
>> > >> > > >> >
>> > >> > > >> > itests-cmp2-cmrmapping
>> > >> > > >> > itests-cmp2-petstore
>> > >> > > >> > itests-cmp2-prefetch
>> > >> > > >> > itests-cmp2-storage
>> > >> > > >> > itests-itests-core
>> > >> > > >> > itests-security-001
>> > >> > > >> > itests-security-002
>> > >> > > >> > itests-security-003
>> > >> > > >> > openejb
>> > >> > > >> > openejb-builder
>> > >> > > >> > openejb-corba
>> > >> > > >> > openejb-corba-builder
>> > >> > > >> > openejb-core
>> > >> > > >> > openejb-itests
>> > >> > > >> > openejb-pkgen-builder
>> > >> > > >> > openejb-sunorb
>> > >> > > >> > openejb-yoko
>> > >> > > >> >
>> > >> > > >> > Does this look good ?  Or should we move the
itests
>> > >> artifacts one
>> > >> > > >> > level down to groupId "o.a.openejb.itests"
?
>> > >> > > >>
>> > >> > > >> Let's keep it in o.a.openejb for now as that's the
way it
>> > >> is in 3.x.
>> > >> > > >>
>> > >> > > >> > For now, I shall put all the tests into 1 artifact
>> > >> module. We
>> > >> > > >> should
>> > >> > > >> > look at breaking them and putting them with
their
>> > >> respective bean
>> > >> > > >> > modules later on.
>> > >> > > >>
>> > >> > > >> What's the issue with doing that now?
>> > >> > > >>
>> > >> > > >> -David
>> > >> > > >>
>> > >> > > >>
>> > >> > > >
>> > >> > >
>> > >> > >
>> > >> >
>> > >>
>> > >> <itests-core.patch>
>> >
>> >
>>
>> <small-tweak-itests.patch>


Mime
View raw message