geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacek Laskowski" <ja...@laskowski.net.pl>
Subject Re: svn commit: r462587 - in /geronimo/server/trunk: configs/client-deployer/src/plan/ modules/geronimo-connector-builder/src/main/java/org/apache/geronimo/connector/deployment/
Date Wed, 11 Oct 2006 06:21:33 GMT
On 10/10/06, djencks@apache.org <djencks@apache.org> wrote:
> Author: djencks
> Date: Tue Oct 10 14:36:45 2006
> New Revision: 462587
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=462587
> Log:
> GERONIMO-2383 Forgot the isMergeEnvironment in a couple builders.  Give client builder
its own ref builders
...
> +    protected boolean willMergeEnvironment(XmlObject specDD, XmlObject plan) {
> +        return specDD.selectChildren(adminOjbectRefQNameSet).length > 0 || specDD.selectChildren(messageDestinationRefQNameSet).length
> 0;
> +    }
...
> +    protected boolean willMergeEnvironment(XmlObject specDD, XmlObject plan) {
> +        return specDD.selectChildren(resourceRefQNameSet).length > 0;
> +    }
> +

I'm kind of confused. You wrote isMergeEnvironment in the commit log
whereas the method name starts with 'will'. I think you were right in
your commit log as it tests not does something.

Jacek

-- 
Jacek Laskowski
http://www.laskowski.net.pl

Mime
View raw message