Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 4147 invoked from network); 19 Sep 2006 17:09:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Sep 2006 17:09:07 -0000 Received: (qmail 80303 invoked by uid 500); 19 Sep 2006 17:09:03 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 80266 invoked by uid 500); 19 Sep 2006 17:09:03 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 80232 invoked by uid 99); 19 Sep 2006 17:09:03 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Sep 2006 10:09:03 -0700 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received: from ([209.237.227.198:53334] helo=brutus.apache.org) by idunn.apache.osuosl.org (ecelerity 2.1 r(10620)) with ESMTP id DE/84-28275-E2420154 for ; Tue, 19 Sep 2006 10:09:03 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 612B441006A for ; Tue, 19 Sep 2006 17:05:27 +0000 (GMT) Message-ID: <26079782.1158685527394.JavaMail.jira@brutus> Date: Tue, 19 Sep 2006 10:05:27 -0700 (PDT) From: "David Jencks (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Created: (GERONIMO-2416) ProxyMethodInterceptor should work with classes that have start,stop methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ProxyMethodInterceptor should work with classes that have start,stop methods ---------------------------------------------------------------------------- Key: GERONIMO-2416 URL: http://issues.apache.org/jira/browse/GERONIMO-2416 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Components: kernel Affects Versions: 1.2 Reporter: David Jencks Assigned To: Dain Sundstrom Priority: Critical Fix For: 1.2 jetty6 components usually have lifecycle methods start,stop, and possibly others. If we write a gbean extending these objects ProxyMethodInterceptor blows up with an ArrayIndexOutOfBoundsException (-1). I don't understand why this happens, and there might be a different cause, but the gbeans that have this problem all extend jetty objects with start methods. A really bad workaround that lets the server start is this patch: Index: modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/basic/ProxyMethodInterceptor.java =================================================================== --- modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/basic/ProxyMethodInterceptor.java (revision 447903) +++ modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/basic/ProxyMethodInterceptor.java (working copy) @@ -110,14 +110,29 @@ invokers[getSuperIndex(proxyType, proxyType.getMethod("equals", new Class[]{Object.class}))] = new EqualsInvoke(kernel); invokers[getSuperIndex(proxyType, proxyType.getMethod("hashCode", null))] = new HashCodeInvoke(); invokers[getSuperIndex(proxyType, proxyType.getMethod("toString", null))] = new ToStringInvoke(proxyType.getName()); - if(GeronimoManagedBean.class.isAssignableFrom(proxyType)) { - invokers[getSuperIndex(proxyType, proxyType.getMethod("getState", null))] = new GetStateInvoke(kernel); - invokers[getSuperIndex(proxyType, proxyType.getMethod("getStateInstance", null))] = new GetStateInstanceInvoke(kernel); - invokers[getSuperIndex(proxyType, proxyType.getMethod("start", null))] = new StartInvoke(kernel); - invokers[getSuperIndex(proxyType, proxyType.getMethod("startRecursive", null))] = new StartRecursiveInvoke(kernel); - invokers[getSuperIndex(proxyType, proxyType.getMethod("stop", null))] = new StopInvoke(kernel); - invokers[getSuperIndex(proxyType, proxyType.getMethod("getStartTime", null))] = new GetStartTimeInvoke(kernel); - invokers[getSuperIndex(proxyType, proxyType.getMethod("getObjectName", null))] = new GetObjectNameInvoke(kernel); + if (GeronimoManagedBean.class.isAssignableFrom(proxyType)) { + int superIndex; + if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getState", null))) > -1) { + invokers[superIndex] = new GetStateInvoke(kernel); + } + if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getStateInstance", null))) > -1) { + invokers[superIndex] = new GetStateInstanceInvoke(kernel); + } + if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("start", null))) > -1) { + invokers[superIndex] = new StartInvoke(kernel); + } + if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("startRecursive", null))) > -1) { + invokers[superIndex] = new StartRecursiveInvoke(kernel); + } + if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("stop", null))) > -1) { + invokers[superIndex] = new StopInvoke(kernel); + } + if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getStartTime", null))) > -1) { + invokers[superIndex] = new GetStartTimeInvoke(kernel); + } + if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getObjectName", null))) > -1) { + invokers[superIndex] = new GetObjectNameInvoke(kernel); + } } } catch (Exception e) { // this can not happen... all classes must implement equals, hashCode and toString Dain, do you have any clues why this is happening? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira