Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <2260553.1158096382901.JavaMail.jira@brutus>
Date: Tue, 12 Sep 2006 14:26:22 -0700 (PDT)
From: "Chris Cardona (JIRA)" <dev@geronimo.apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-2333) Add JMX Portlet
In-Reply-To: <30992173.1155932473848.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/GERONIMO-2333?page=comments#action_12434280 ] 
            
Chris Cardona commented on GERONIMO-2333:
-----------------------------------------

> Chris the new portlet looks fantastic!!  It will be a huge help for 
> administrators and developers needing to explore the server.  I 
> especially like the well designed use of ajax controls.
>

Paul, thanks for finding time to check this patch. Your comments and suggestions are very helpful. Please see my comments below:

> A few comments to consider before this is committed.  I would be 
> happy to help follow up on any of these items, just let me know:
> -  I think that the dojo license is compatible with ASL but before 
> embedding it in the server I think the Geronimo PMC should be 
> notified and allowed to make an "official" decision on its inclusion

I agree. I will send out an email to the devlist regarding this.

> -  At one time there was an attempt to convert all use of ObjectName > over to AbstractName so certain deprecated methods could be removed 
> from the kernel, but I don't know where that stands now.  If 
> replacing ObjectNames with AbstractNames is not simple then can you  > check on the dev list to see if introducing more of use of it creates > any concern?

I'm already using AbstractNames in my patch when possible. The only part where I used ObjectNames is for objectname patterns when searching MBeans. I haven't found a solution to use AbstractNames for cases where the search pattern specifies only domain names - e.g. geronimo.config:*. Hopefully somebody with a solution can comment on this.

> -  A few new files need copyright headers (e.g. viewJMXServer.jsp)

I intentionally didn't add copyright headers on the jsp files because we never did in our console code. No biggie, I'll include these changes in a new patch.

> -  Since this is a new feature can you provide a patch for trunk 
> instead of the 1.1.x branch?  I think the only real difference in 
> trunk is that the console directories were moved.

I'm working on this right now. I'll update this jira when the patch is done.

> -  The "JMX Viewer" link in the Console Navigation area should maybe > go in the Server folder instead of a new top level item.  But I can 
> go either way if there are strong opinions otherwise.

That works for me too but I'm also open to other suggestions. This is easy to change so I would love to know what others think about this.

> -  Need to test on safari, konqueror, and opera.  I'll do this 
> tonight if possible and update the JIRA with results.

Thanks for helping on this. I'll also try testing it on Opera and Konqueror.

> -  Later we may want to separate the dojo library into a plugin like 
> was discussed on the dev list. I think the way you've implemented 
> this portlet will facilitate that approach, is that true?
>

AFAIK, if we finally agree to do this I don't see any potential problem with my current implementation.

> Here are a few suggestions for if /when you or someone else want to 
> make some improvements.   IMO these changes are not required before 
> commiting.

> -  When a user clicks on a leaf node it loads data into the notebook > area.  To avoid confusion I recommend clearing that data when they 
> click on a group node.

No problem with this. I think I can squeeze this in the new patch.

> -  At first it wasn't obvious to me that there's a lot more data in 
> the notebook area if you scroll right.  If the dojo table widget can > do resizable columns then that would help.

We can include this next time.

> -  It would be nice if the mouse pointer glyph changed to an hour 
> glass while data was loading from the server.  For example, some 
> actions like initial bringup, loading data into the notebook area, or > expanding the "All MBeans-->geronimo" node take several seconds.  
> Providing an indication that the UI was processing their request 
> would keep them from re-clicking or wondering if the UI is hung.
>

I agree. Actually, I got stuck looking for a solution to this so I decided to save this under my todo bucket.

> Again, nice work!

Thanks again for your comments and suggestions.

Best wishes,
chris

> Add JMX Portlet
> ---------------
>
>                 Key: GERONIMO-2333
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2333
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 1.2
>            Reporter: Chris Cardona
>         Assigned To: Chris Cardona
>         Attachments: dojo-0.3.1-bin.zip, jmxMgrPortlet-G1.1.1-1.jpg, jmxMgrPortlet-G1.1.1-2.jpg, jmxMgrPortlet-G1.1.1-3.jpg, jmxMgrPortlet-G1.1.1-New.patch, jmxMgrPortlet-G1.1.1.patch
>
>
> Add a JMX portlet with the following minimum capabilities:
> 1. Be able to list all the MBeans
> 2. Predefined searches for the different J2EE types: J2EEApplication, EJBModule, WebModule, Sertlet, JCAConnectionFactory, etc.
> 3. Be able to query MBeans (if possible with autocomplete feature)
> 4. View the attributes and operations of MBeans
> The plan is to use Ajax (Dojo and DWR) to make this portlet a little bit responsive. Any thoughts and suggestions are welcome.
> cheers,
> chris

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira