Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 40536 invoked from network); 10 Sep 2006 18:00:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Sep 2006 18:00:04 -0000 Received: (qmail 23453 invoked by uid 500); 10 Sep 2006 18:00:04 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 22815 invoked by uid 500); 10 Sep 2006 18:00:02 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 22804 invoked by uid 99); 10 Sep 2006 18:00:02 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Sep 2006 11:00:02 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Sep 2006 11:00:01 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 638007142D9 for ; Sun, 10 Sep 2006 17:56:23 +0000 (GMT) Message-ID: <16215265.1157910983404.JavaMail.jira@brutus> Date: Sun, 10 Sep 2006 10:56:23 -0700 (PDT) From: "David Jencks (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMO-2383) Replace ENCConfigBuilder with a pluggable set of NamingBuilders In-Reply-To: <26594234.1157480482438.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/GERONIMO-2383?page=comments#action_12433713 ] David Jencks commented on GERONIMO-2383: ---------------------------------------- re gianni's comment: Althought, it seems that it is possible to have a successful deployment which is actually not successful (for instance if a NamingBuilder is wrongly stopped, then some naming elements may not be honored.). I'm aware of this, and think that we can add a set of required qnames to the NamingBuilderCollection. Then we add e.g. all the j2ee 1.4 jndi elements to it. The main work is writing a property editor or xml-attribute editor for a qname set. I'm thinking of doing this after this patch is applied as a bug fix, but might get to it sooner. > Replace ENCConfigBuilder with a pluggable set of NamingBuilders > --------------------------------------------------------------- > > Key: GERONIMO-2383 > URL: http://issues.apache.org/jira/browse/GERONIMO-2383 > Project: Geronimo > Issue Type: Improvement > Security Level: public(Regular issues) > Affects Versions: 1.2 > Reporter: David Jencks > Assigned To: David Jencks > Fix For: 1.2 > > Attachments: GERONIMO-2383-openejb-v2.patch, GERONIMO-2383-v2.patch > > > (Previously part of GERONIMO-2349) > The ENCConfigBuilder is way too hardcoded into what it accepts and how. It won't let you add things like a persistence-ref builder very easily. We can replace it with a set of NamingBuilders somewhat similar to NamespaceDrivenBuilders. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira