geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul McMahan (JIRA)" <>
Subject [jira] Commented: (GERONIMO-2381) DB Manager portlet - Form field validation using javascript
Date Fri, 08 Sep 2006 19:19:23 GMT
    [ ] 
Paul McMahan commented on GERONIMO-2381:

Vamsi,  comments on this patch:

Instead of prompting the user with the form's internal variable names it would be more helpful
to use the display name or say something like "please specify a database name".
Also, there is already code on the server to check for non-empty SQL, and it displays a message
that matches the display name.  I suggest either removing the client side check for SQL introduced
in this patch or make the client side prompt use the form's display name.

> DB Manager portlet - Form field validation using javascript
> -----------------------------------------------------------
>                 Key: GERONIMO-2381
>                 URL:
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 1.1.1
>         Environment: WinXP, G 1.1.1-rc1
>            Reporter: Vamsavardhana Reddy
>             Fix For: 1.2, 1.1.x, 1.1.2
>         Attachments: GERONIMO-2381.patch
> Form field validation in DB Manager portlet using javascript.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message