geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <...@geronimo.apache.org>
Subject [jira] Created: (GERONIMO-2416) ProxyMethodInterceptor should work with classes that have start,stop methods
Date Tue, 19 Sep 2006 17:05:27 GMT
ProxyMethodInterceptor should work with classes that have start,stop methods
----------------------------------------------------------------------------

                 Key: GERONIMO-2416
                 URL: http://issues.apache.org/jira/browse/GERONIMO-2416
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: kernel
    Affects Versions: 1.2
            Reporter: David Jencks
         Assigned To: Dain Sundstrom
            Priority: Critical
             Fix For: 1.2


jetty6 components usually have lifecycle methods start,stop, and possibly others.  If we write
a gbean extending these objects ProxyMethodInterceptor blows up with an ArrayIndexOutOfBoundsException
(-1).  I don't understand why this happens, and there might be a different cause, but the
gbeans that have this problem all extend jetty objects with start methods.

A really bad workaround that lets the server start is this patch:

Index: modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/basic/ProxyMethodInterceptor.java
===================================================================
--- modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/basic/ProxyMethodInterceptor.java
 (revision 447903)
+++ modules/geronimo-kernel/src/main/java/org/apache/geronimo/kernel/basic/ProxyMethodInterceptor.java
 (working copy)
@@ -110,14 +110,29 @@
             invokers[getSuperIndex(proxyType, proxyType.getMethod("equals", new Class[]{Object.class}))]
= new EqualsInvoke(kernel);
             invokers[getSuperIndex(proxyType, proxyType.getMethod("hashCode", null))] = new
HashCodeInvoke();
             invokers[getSuperIndex(proxyType, proxyType.getMethod("toString", null))] = new
ToStringInvoke(proxyType.getName());
-            if(GeronimoManagedBean.class.isAssignableFrom(proxyType)) {
-                invokers[getSuperIndex(proxyType, proxyType.getMethod("getState", null))]
= new GetStateInvoke(kernel);
-                invokers[getSuperIndex(proxyType, proxyType.getMethod("getStateInstance",
null))] = new GetStateInstanceInvoke(kernel);
-                invokers[getSuperIndex(proxyType, proxyType.getMethod("start", null))] =
new StartInvoke(kernel);
-                invokers[getSuperIndex(proxyType, proxyType.getMethod("startRecursive", null))]
= new StartRecursiveInvoke(kernel);
-                invokers[getSuperIndex(proxyType, proxyType.getMethod("stop", null))] = new
StopInvoke(kernel);
-                invokers[getSuperIndex(proxyType, proxyType.getMethod("getStartTime", null))]
= new GetStartTimeInvoke(kernel);
-                invokers[getSuperIndex(proxyType, proxyType.getMethod("getObjectName", null))]
= new GetObjectNameInvoke(kernel);
+            if (GeronimoManagedBean.class.isAssignableFrom(proxyType)) {
+                int superIndex;
+                if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getState",
null))) > -1) {
+                    invokers[superIndex] = new GetStateInvoke(kernel);
+                }
+                if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getStateInstance",
null))) > -1) {
+                    invokers[superIndex] = new GetStateInstanceInvoke(kernel);
+                }
+                if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("start", null)))
> -1) {
+                    invokers[superIndex] = new StartInvoke(kernel);
+                }
+                if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("startRecursive",
null))) > -1) {
+                    invokers[superIndex] = new StartRecursiveInvoke(kernel);
+                }
+                if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("stop", null)))
> -1) {
+                    invokers[superIndex] = new StopInvoke(kernel);
+                }
+                if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getStartTime",
null))) > -1) {
+                    invokers[superIndex] = new GetStartTimeInvoke(kernel);
+                }
+                if ((superIndex = getSuperIndex(proxyType, proxyType.getMethod("getObjectName",
null))) > -1) {
+                    invokers[superIndex] = new GetObjectNameInvoke(kernel);
+                }
             }
         } catch (Exception e) {
             // this can not happen... all classes must implement equals, hashCode and toString

Dain, do you have any clues why this is happening?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message