Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 42062 invoked from network); 22 Aug 2006 15:01:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Aug 2006 15:01:28 -0000 Received: (qmail 35381 invoked by uid 500); 22 Aug 2006 15:01:24 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 35259 invoked by uid 500); 22 Aug 2006 15:01:24 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 35248 invoked by uid 99); 22 Aug 2006 15:01:24 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2006 08:01:24 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of gnodet@gmail.com designates 64.233.182.184 as permitted sender) Received: from [64.233.182.184] (HELO nf-out-0910.google.com) (64.233.182.184) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2006 08:01:22 -0700 Received: by nf-out-0910.google.com with SMTP id n29so81707nfc for ; Tue, 22 Aug 2006 08:01:00 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=HaZ6vai6GTAtQ7od4pwk0VNSe7tTD+u7j4j2FBKkFozF2scW/Y4l1Va7bEcum0ufCeCVjUmfAesnagRfQknl2G+bevec2eXY5BlpLCjgofW33dkxso+zY6pKJ8l2atHoTOUo45lP2BK/dFbjPDxdjVBsRa6qpFjdqejEtvcjvk4= Received: by 10.49.8.4 with SMTP id l4mr516787nfi; Tue, 22 Aug 2006 08:01:00 -0700 (PDT) Received: by 10.49.85.1 with HTTP; Tue, 22 Aug 2006 08:01:00 -0700 (PDT) Message-ID: Date: Tue, 22 Aug 2006 17:01:00 +0200 From: "Guillaume Nodet" To: dev@geronimo.apache.org Subject: Re: Car plugin In-Reply-To: <74e15baa0608220751od6d05c5va3784a9e972386b9@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_14173_31101577.1156258860544" References: <1b5bfeb50608220601j735d47alaf8a8a9e47ec9672@mail.gmail.com> <01E654A4-AB6F-481A-BD55-22B8263EE319@yahoo.com> <74e15baa0608220705k41aae694g489eb9054a17f0d9@mail.gmail.com> <74e15baa0608220714v53668b40hfb3861e68e49ffa5@mail.gmail.com> <74e15baa0608220751od6d05c5va3784a9e972386b9@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_14173_31101577.1156258860544 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline I will start a new discussion thread about that. On 8/22/06, Aaron Mulder wrote: > > Ah, I see -- it's that the plugin plan writing causes problems. > > In any case, I agree that it would be nice to have a dedicated G 1.1 > version of the car-maven-plugin. > > Thanks, > Aaron > > On 8/22/06, Guillaume Nodet wrote: > > On 8/22/06, Aaron Mulder wrote: > > > On 8/22/06, Guillaume Nodet wrote: > > > > > I think any problem with the deployer can be avoided by specifying > the > > > > > correct set of dependencies and configuration info in the project > POM > > > > > (to force it to use only 1.1 JARs/CARs and the 1.1 deployer > GBean). > > > > > But if any of the kernel/system interfaces changed, that would > > > > > probably stop working. > > > > > > > > Actually, that' s the main problem. > > > > > > I'm not convinced. If I understand this correctly, you got a problem > > > when the G 1.2 service builder attempted to do something with a G 1.1 > > > deployment plan. I think you can avoid the 1.2 service builder being > > > invoked by listing all the 1.1 dependencies explicitly. Is that not > > > what's going on? > > > > The problem is very simple. That processed plan begins with > > > > > > > > which is rejected when deployed on G 1.1. > > Btw, it really sounds weird that the plugin process the environment tag, > but not > > the module tag... > > My fix is to allow specifying the target geronimo version, so that the > plugin > > will build the namespace uri dynamically: URI_PREFIX + 1.2. This works. > > > > What I meant, is that I' m not convinced that the API will never change > and > > that a single plugin will be able to handle all versions in the future. > > This is already the case for the schema which are upgraded by default, > even > > if no change happen (I do not argue against that, just stating the > fact). But > > if something change, the plugin will need to cope with the difference. > > Is that what we want ? > > > > Also, I think it would be good to be able to release the plugin without > having > > to wait for G 1.2 final, so that users can build G 1.1 plugins easily. > > > > > > > > Thanks, > > > Aaron > > > > > > > > > > > > >> > > > > > > >> Adding a property to specify the target geronimo version > seems to > > > > > > >> do the trick. > > > > > > >> So i can now have: > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> instead of > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> Btw, I' m wondering why the PlanProcessorMojo only overrides > the > > > > > > >> environmnet > > > > > > >> tag, and not the module one. > > > > > > >> > > > > > > >> > > > > > > >> On 8/22/06, Jacek Laskowski wrote: > > > > > > >> > On 8/22/06, Guillaume Nodet wrote: > > > > > > >> > > I recently experienced some problems [1] when building > > > > > > >> Geronimo 1.1 > > > > > > >> > > plugins using > > > > > > >> > > the car-maven-plugin. > > > > > > >> > > > > > > > >> > I think a solution may be to build the maven plugin locally > from > > > > > > >> 1.1 > > > > > > >> > sources and build Geronimo 1.1 then. It seems you've been > trying to > > > > > > >> > run the build online and thus all the deps (the maven > plugin > > > > > > >> > including) is pulled down too. For it's an incompatible > version, > > > > > > >> the > > > > > > >> > build blows up. > > > > > > >> > > > > > > > >> > Just a wild guess, but may be of help. Report back! ;-) > > > > > > >> > > > > > > > >> > Jacek > > > > > > >> > > > > > > > >> > -- > > > > > > >> > Jacek Laskowski > > > > > > >> > http://www.laskowski.net.pl > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > > >> -- > > > > > > >> Cheers, > > > > > > >> Guillaume Nodet > > > > > > >> > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Cheers, > > > > > > > Guillaume Nodet > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Cheers, > > > > Guillaume Nodet > > > > > > > > > > > > > -- > > Cheers, > > Guillaume Nodet > > > -- Cheers, Guillaume Nodet ------=_Part_14173_31101577.1156258860544 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline I will start a new discussion thread about that.

On 8/22/06, Aaron Mulder <ammulder@alumni.princeton.edu > wrote:
Ah, I see -- it's that the plugin plan writing causes problems.

In any case, I agree that it would be nice to have a dedicated G 1.1
version of the car-maven-plugin.

Thanks,
    Aaron

On 8/22/06, Guillaume Nodet <gnodet@gmail.com > wrote:
> On 8/22/06, Aaron Mulder <ammulder@alumni.princeton.edu> wrote:
> > On 8/22/06, Guillaume Nodet < gnodet@gmail.com> wrote:
> > > > I think any problem with the deployer can be avoided by specifying the
> > > > correct set of dependencies and configuration info in the project POM
> > > > (to force it to use only 1.1 JARs/CARs and the 1.1 deployer GBean).
> > > > But if any of the kernel/system interfaces changed, that would
> > > > probably stop working.
> > >
> > > Actually, that' s the main problem.
> >
> > I'm not convinced.  If I understand this correctly, you got a problem
> > when the G 1.2 service builder attempted to do something with a G 1.1
> > deployment plan.  I think you can avoid the 1.2 service builder being
> > invoked by listing all the 1.1 dependencies explicitly.  Is that not
> > what's going on?
>
> The problem is very simple.  That processed plan begins with
> <module xmlns="http://geronimo.apache.org/xml/ns/deployment-1.1">
>  <environment xmlns=" http://geronimo.apache.org/xml/ns/deployment-1.2">
>
> which is rejected when deployed on G 1.1.
> Btw, it really sounds weird that the plugin process the environment tag, but not
> the module tag...
> My fix is to allow specifying the target geronimo version, so that the plugin
> will build the namespace uri dynamically: URI_PREFIX + 1.2. This works.
>
> What I meant, is that I' m not convinced that the API will never change and
> that a single plugin will be able to handle all versions in the future.
> This is already the case for the schema which are upgraded by default, even
> if no change happen (I do not argue against that, just stating the fact).  But
> if something change, the plugin will need to cope with the difference.
> Is that what we want ?
>
> Also, I think it would be good to be able to release the plugin without having
> to wait for G 1.2 final, so that users can build G 1.1 plugins easily.
>
> >
> > Thanks,
> >      Aaron
> >
> >
> > > > > >>
> > > > > >> Adding a property to specify the target geronimo version seems to
> > > > > >> do the trick.
> > > > > >> So i can now have:
> > > > > >>
> > > > > >> <module xmlns=" http://geronimo.apache.org/xml/ns/deployment-1.1">
> > > > > >>   <environment>
> > > > > >>
> > > > > >> instead of
> > > > > >>
> > > > > >> <module xmlns="http://geronimo.apache.org/xml/ns/deployment-1.1">
> > > > > >>   <environment xmlns=" http://geronimo.apache.org/xml/ns/
> > > > > >> deployment-1.2">
> > > > > >>
> > > > > >> Btw, I' m wondering why the PlanProcessorMojo only overrides the
> > > > > >> environmnet
> > > > > >> tag, and not the module one.
> > > > > >>
> > > > > >>
> > > > > >> On 8/22/06, Jacek Laskowski < jacek@laskowski.net.pl> wrote:
> > > > > >> > On 8/22/06, Guillaume Nodet <gnodet@gmail.com> wrote:
> > > > > >> > > I recently experienced some problems [1] when building
> > > > > >> Geronimo 1.1
> > > > > >> > > plugins using
> > > > > >> > > the car-maven-plugin.
> > > > > >> >
> > > > > >> > I think a solution may be to build the maven plugin locally from
> > > > > >> 1.1
> > > > > >> > sources and build Geronimo 1.1 then. It seems you've been trying to
> > > > > >> > run the build online and thus all the deps (the maven plugin
> > > > > >> > including) is pulled down too. For it's an incompatible version,
> > > > > >> the
> > > > > >> > build blows up.
> > > > > >> >
> > > > > >> > Just a wild guess, but may be of help. Report back! ;-)
> > > > > >> >
> > > > > >> > Jacek
> > > > > >> >
> > > > > >> > --
> > > > > >> > Jacek Laskowski
> > > > > >> > http://www.laskowski.net.pl
> > > > > >> >
> > > > > >>
> > > > > >>
> > > > > >> --
> > > > > >> Cheers,
> > > > > >> Guillaume Nodet
> > > > > >>
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Cheers,
> > > > > > Guillaume Nodet
> > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Cheers,
> > > Guillaume Nodet
> > >
> >
>
>
> --
> Cheers,
> Guillaume Nodet
>



--
Cheers,
Guillaume Nodet ------=_Part_14173_31101577.1156258860544--