Return-Path: 
 <dev-return-37430-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 84501 invoked from network); 30 Aug 2006 19:33:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 30 Aug 2006 19:33:20 -0000
Received: (qmail 57776 invoked by uid 500); 30 Aug 2006 19:33:13 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 57735 invoked by uid 500); 30 Aug 2006 19:33:13 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 57724 invoked by uid 99); 30 Aug 2006 19:33:13 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2006 12:33:13 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Received: from [66.94.9.112] (HELO svcstsnq08.hotspot.t-mobile.com)
 (66.94.9.112)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2006 12:33:12 -0700
Received: from [10.254.49.118] (118.49.254.10.in-addr.arpa [10.254.49.118])
	by svcstsnq08.hotspot.t-mobile.com (8.12.10+Sun/8.12.10) with ESMTP id
 k7UJVh2r008373
	for <dev@geronimo.apache.org>; Wed, 30 Aug 2006 12:31:51 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v752.2)
In-Reply-To: <3C56BE47-590B-4887-9919-9A6BC7E1DD4C@planet57.com>
References: <1B1842CD-CF73-4B16-9ABE-75F5EEECA953@apache.org>
 <9BE0B047-0CFE-416A-87C8-459AEA9E4518@planet57.com>
 <2DFB3B1D-28FC-4CEF-82D7-C029BAFA764D@apache.org>
 <8701D6B6-E6CF-4471-B0B3-6DA0CDF4ED75@planet57.com>
 <0C508275-0618-4764-8330-AF77BC0489C9@apache.org>
 <E7B12BE5-C767-478B-8760-4DB166FA74DE@planet57.com>
 <7E26B950-696F-4701-B999-BC56C3761406@apache.org>
 <D2F68765-0C30-4C15-A42B-5EC9372C266A@planet57.com>
 <3E18F36F-4731-42D6-93F4-5E199FD3AD7A@apache.org>
 <3C56BE47-590B-4887-9919-9A6BC7E1DD4C@planet57.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <74FB6454-153B-497E-884A-513FA2A78A4A@apache.org>
Content-Transfer-Encoding: 7bit
From: Bill Dudney <bdudney@apache.org>
Subject: Re: j2ee-builder tests?
Date: Wed, 30 Aug 2006 13:31:45 -0600
To: dev@geronimo.apache.org
X-Mailer: Apple Mail (2.752.2)
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlx=0
 adultscore=0 adjust=0 reason=mlx engine=3.1.0-0608080000
 definitions=main-0608300003
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Hi Jason,

On Aug 29, 2006, at 3:18 PM, Jason Dillon wrote:

> On Aug 29, 2006, at 12:07 PM, Bill Dudney wrote:
>> 1) The dependency plugin version 2.0-SNAPSHOT is all that appears  
>> to work. I could not find a functional 1.0 version of this plugin.  
>> I guess the question here is what is the community stance on using  
>> snapshots of plugins for the build? If this is not OK we need to  
>> get on the maven lists and try to get a released version of the  
>> dependency plugin. I found a couple of posts on the maven lists  
>> that make me hope that a 2.0 release is going to happen soon but I  
>> don't follow the maven community that closely so I'm not sure.
>
> We are already using 1.0 of the dependency plugin...
>
>                 <plugin>
>                     <groupId>org.codehaus.mojo</groupId>
>                     <artifactId>dependency-maven-plugin</artifactId>
>                     <version>1.0</version>
>                 </plugin>
>

I was using maven-dependency-plugin and following the docs here;
http://maven.apache.org/plugins/maven-dependency-plugin/ 
introduction.html

changed to match what is in the other poms (org.codehaus.mojo) and  
works fine.

>
>> 2) The j2ee-builder tests use a 'naked' ear that has been stripped  
>> of its geronimo-application.xml file. Easy enough to do with ant  
>> and we can do it with maven as well I'm sure but I was hoping  
>> you'd have some ideas about how to do it more simply that what I  
>> was thinking. Here are my two ideas;
>> 	a) adopt an approach similar to the boilerplate-{j2ee,minimal} in  
>> the assembly build
>> 	b) use something in the dependency plugin that can strip various  
>> elements from a jar file
>> 	c) unpack it then repack with the geronimo-application.xml file  
>> excluded
>
> What else is in the ear?  Sounds like a normal jar module would be  
> fine.

ear depends on war, rar & ejb, so there is virtually nothing in the  
ear, just the geroinmo-application.xml and application.xml.

I'll submit the patch we can mess with these changes later.

>
>
>> 3) There are a couple of more testing bits in the geronimo-j2ee- 
>> builder module. I'm not sure what the best way to remove them is.
>> 	a) src/test-plan - has some bad plan files that ensure that  
>> failure happens when expected. I think these should be moved into  
>> src/test/resources and used from there in the tests but wanted to  
>> get your take.
>> 	b) src/test-unpacked-ear is another set of deployment descriptors  
>> and plans used for both positive and negative tests. Again these  
>> could/should probably be moved into the src/test/resources  
>> directory (when its created until then it looks like src/test is  
>> the destination)
>
> Um... okay... no opinion on this right now.
>

K - I moved them and updated the tests to use the stuff from the new  
location.

You can delete modules/geronimo-j2ee-modules/{test-ear, test-ear13,  
test-plan, test-unpacked-ear} after the patch is applied.

TTFN,

-bd-

> --jason
>