Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 94415 invoked from network); 8 Aug 2006 23:51:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 8 Aug 2006 23:51:42 -0000 Received: (qmail 35720 invoked by uid 500); 8 Aug 2006 23:51:39 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 35674 invoked by uid 500); 8 Aug 2006 23:51:39 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 35663 invoked by uid 99); 8 Aug 2006 23:51:39 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Aug 2006 16:51:39 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [66.116.97.229] (HELO mail.dudney.net) (66.116.97.229) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Aug 2006 16:51:38 -0700 Received: from localhost (localhost [127.0.0.1]) by mail.dudney.net (Postfix) with ESMTP id A4A292DFF38 for ; Tue, 8 Aug 2006 17:51:18 -0600 (MDT) Received: from mail.dudney.net ([127.0.0.1]) by localhost (mini.dudney.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 26004-06 for ; Tue, 8 Aug 2006 17:48:54 -0600 (MDT) Received: from [192.168.1.101] (c-24-9-189-43.hsd1.wa.comcast.net [24.9.189.43]) by mail.dudney.net (Postfix) with ESMTP id 5FEEB2DFDDD for ; Tue, 8 Aug 2006 17:48:54 -0600 (MDT) Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: <0DAD13DC-61BC-40CE-8058-FE640ACD12AA@planet57.com> References: <0DAD13DC-61BC-40CE-8058-FE640ACD12AA@planet57.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <74DB1627-84F4-48AF-AE5E-FAC395A3F03D@apache.org> Content-Transfer-Encoding: 7bit From: Bill Dudney Subject: Re: [itests] Modify the geronimo-deployment-plugin ? Date: Tue, 8 Aug 2006 17:48:54 -0600 To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.752.2) X-Virus-Scanned: by amavisd-new at dudney.net X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Cool thing is someone else has already done it Cargo currently supports G 1.1. :-) -bd- On Aug 8, 2006, at 5:33 PM, Jason Dillon wrote: > I think that in general it would be good to have cargo support :-) > > --jason > > > On Aug 8, 2006, at 4:23 PM, Bill Dudney wrote: > >> Hi Prasad, >> >> The cargo plugins [1] might be another place to check to start and >> stop the server. >> >> I've used them before for tomcat and its good stuff for running >> integration tests. >> >> And what can I do to help? >> >> TTFN, >> >> -bd- >> >> [1] http://cargo.codehaus.org >> >> On Aug 4, 2006, at 10:00 AM, Prasad Kashyap wrote: >> >>> With the m2migration ready to be merged into trunk, I have resumed >>> work on the itests for Geronimo again. >>> >>> Approx 30% of our code is covered by component level tests that are >>> embedded in each module. These tests are written as junit test cases >>> and run by Maven surefire plugin. >>> >>> The itests will cover system level tests by testing the >>> functionalities that an end-user would use on a fully assembled >>> Geronimo distribution. Therefore to the extent possible, our itests >>> and it's testcases should use the very same external APIs and >>> workflows that a user would use. >>> >>> We have been using the startRemoteServer and stopRemoteServer >>> goals in >>> the geronimo-deployment-plugin (g-d-p) to start and stop a >>> server. We >>> have always used these "remote" goals and have never used the in-vm >>> goals startServer and stopServer. >>> >>> I propose that we convert the in-vm goals startServer and stopServer >>> to be ant mojos from their existing java mojos. Invoking the ant >>> mojo >>> goals in our itests will ensure that our tests are using the same >>> APIs >>> that a end-user uses. Thus we shall no longer use internal hooks in >>> the code to start and stop the server. >>> >>> Thoughts ? Comments ? Advice ? >>> >>> Cheers >>> Prasad >> >