Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 17809 invoked from network); 1 Aug 2006 16:22:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Aug 2006 16:22:51 -0000 Received: (qmail 66900 invoked by uid 500); 1 Aug 2006 16:22:48 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 66765 invoked by uid 500); 1 Aug 2006 16:22:47 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 66703 invoked by uid 99); 1 Aug 2006 16:22:47 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 09:22:47 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 09:22:45 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 0AFED41001D for ; Tue, 1 Aug 2006 16:20:14 +0000 (GMT) Message-ID: <4179773.1154449214042.JavaMail.jira@brutus> Date: Tue, 1 Aug 2006 09:20:14 -0700 (PDT) From: "Aaron Mulder (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Created: (GERONIMO-2258) Abstract/Maven repositories install modules incorrectly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Abstract/Maven repositories install modules incorrectly ------------------------------------------------------- Key: GERONIMO-2258 URL: http://issues.apache.org/jira/browse/GERONIMO-2258 Project: Geronimo Issue Type: Bug Security Level: public (Regular issues) Components: kernel Affects Versions: 1.1 Reporter: Aaron Mulder Assigned To: Aaron Mulder Fix For: 1.1.1, 1.2 The repository unpacks a JAR when it installs it only if the Artifact type is "car". That is incorrect -- it should unpack any module with META-INF/config.ser (which is the logic that we use in other places, such as RepositoryConfigurationStore). This breaks plugins that don't have the type "car" (such as copying a database pool from server to server). The currently handling attempts to be generic by associating a behavior with each file type, though in practice this is only used for type=car. In the 1.1 branch, I am going to put in a workaround to look up the "car" handler any time we find a META-INF/config.ser (a pretty minimal workaround). In trunk, I think we should remove the behavior/type association and instead have a boolean for whether configurations should be unpacked, or an "ArtifactTypeHandler" property specifically for configurations and another one for non-configurations. I don't see any reason to distinguish based on module type. Input would be appreciated for the 1.2 resolution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira