Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 88183 invoked from network); 24 Aug 2006 18:22:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 24 Aug 2006 18:22:57 -0000 Received: (qmail 6191 invoked by uid 500); 24 Aug 2006 18:22:53 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 6158 invoked by uid 500); 24 Aug 2006 18:22:53 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 6147 invoked by uid 99); 24 Aug 2006 18:22:53 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2006 11:22:53 -0700 X-ASF-Spam-Status: No, hits=1.7 required=10.0 tests=DNS_FROM_RFC_ABUSE,HTML_MESSAGE,RCVD_IN_SORBS_WEB,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of sppatel@gmail.com designates 66.249.82.234 as permitted sender) Received: from [66.249.82.234] (HELO wx-out-0506.google.com) (66.249.82.234) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2006 11:22:52 -0700 Received: by wx-out-0506.google.com with SMTP id i27so555167wxd for ; Thu, 24 Aug 2006 11:22:32 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:mime-version:in-reply-to:references:content-type:message-id:from:subject:date:to:x-mailer:sender; b=eM9ltbAs53jgKXmXPP359TzFIg08FAE4uNDlMj43jP4Re438lDy6gOLq+7Zyksarl/SjTGuRxdzZgi5gnPd3K9FP07Wqsc9DJiQDh2aHwDflPcNMsGgPP6AMuVDhYfKiJo0x530AoVTCwC5gGSK/kKcd3eEGTRQrUEWrIi7Xlns= Received: by 10.70.100.14 with SMTP id x14mr2970893wxb; Thu, 24 Aug 2006 11:22:30 -0700 (PDT) Received: from ?9.27.40.137? ( [129.33.49.251]) by mx.gmail.com with ESMTP id 26sm2689888wrl.2006.08.24.11.22.26; Thu, 24 Aug 2006 11:22:29 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: References: <23D31F5E-5D27-4CB6-AC12-146C97FB9B96@gmail.com> <7B5F9309-69AD-459B-97F1-503A419345D2@iq80.com> <3C6E47B0-3695-4D95-BC7B-1BDD0F62401B@gmail.com> <26D09A82-5896-4029-ABE5-73B262D9FB3D@iq80.com> <5F8E27E8-53FC-4F7D-A1A9-9C8CAF46E310@gmail.com> <204F8BE0-3149-4C14-A0BB-FA0919025D96@gmail.com> <2143537F-644E-4D9C-87F1-14E65654CE5C@gmail.com> <1b5bfeb50608231239g62f8f1e5w68be5b1482150feb@mail.gmail.com> <4E2A9666-5B51-460D-ACC9-A73C9079B1CB@gmail.com> <65267272-BC8C-4A8C-88F2-6EF173C7F021@iq80.com> Content-Type: multipart/alternative; boundary=Apple-Mail-14--104589371 Message-Id: <2B8328DB-61F7-44FE-A158-8D9BA23CE251@gmail.com> From: Sachin Patel Subject: Re: GERONIMO-1526 Date: Thu, 24 Aug 2006 14:22:33 -0400 To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.752.2) Sender: Sachin Patel X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --Apple-Mail-14--104589371 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Agree. Will create a branch. Yes if you could post some instructions on svk that would be great. BTW, what more does svk do compared to svn merge? On Aug 24, 2006, at 2:18 PM, Jason Dillon wrote: > I agree, this is what branches are good for. > > I have been meaning to write a howto doc about how to use svk to > merge branches (not to develop, but just to merge). It works > really well for these types of feature branches to manage conflicts > and to keep feature branches up to date with the latest from the > source tree. Maybe I'll get to that this weekend. > > --jason > > > On Aug 24, 2006, at 11:10 AM, Dain Sundstrom wrote: > >> For a change of this size, I suggest you cut a branch as it will >> let everyone see you work in progress, and I assure it will save >> you during development as you can rollback bad ideas :) >> >> -dain >> >> On Aug 24, 2006, at 10:21 AM, Sachin Patel wrote: >> >>> Please review the following changes, thus far. Please review the >>> changes carefully to be sure I did not break an existing function. >>> >>> The bulk of this change is: >>> >>> (1) Allows a DeployableModuleImpl class to be set for a single >>> deployment via the DeploymentManager (currently the factory only >>> loads the default, need some advice on how best to load the class >>> for other impls) >>> (2) Introduces DefaultDeployableModule implementation of >>> DeployableModule >>> (2) Changes the use of and passing of JarFile throughout the >>> entire deployment process with DeployableModule. >>> >>> Next I plan to fix all the tests that are now broken, then start >>> plugging in a new Impl of DeployableModule for Eclipse support >>> and see if we need to tweak add/remove methods to the interface >>> as I'm not convinced yet that all the methods currently are >>> sufficient. This is where the bulk of the work will be so feel >>> free to help out if interested :). >>> >>> >> > -sachin --Apple-Mail-14--104589371 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=ISO-8859-1 Agree. =A0Will create a branch.=A0= Yes if you could post some instructions on svk that would be great.=A0 = BTW, what more does svk do compared to svn merge?

On Aug 24, 2006, = at 2:18 PM, Jason Dillon wrote:

I agree, this is what branches are good = for.

I have been meaning to write a howto doc about how = to use svk to merge branches (not to develop, but just to merge).=A0 It works really well for = these types of feature branches to manage conflicts and to keep feature = branches up to date with the latest from the source tree.=A0 Maybe I'll get to that this = weekend.

--jason


On Aug 24, 2006, at 11:10 AM, Dain Sundstrom = wrote:

=
For a change of this size, = I suggest you cut a branch as it will let everyone see you work in = progress, and I assure it will save you during development as you can = rollback bad ideas :)
-dain

On Aug = 24, 2006, at 10:21 AM, Sachin Patel wrote:

Please review the following changes, thus far.=A0 Please review the changes = carefully to be sure I did not break an existing function.

The bulk = of this change is:
(1) Allows a = DeployableModuleImpl class to be set for a single deployment via the = DeploymentManager (currently the factory only loads the default, need = some advice on how best to load the class for other impls)
(2) Introduces DefaultDeployableModule = implementation of DeployableModule
(2) Changes = the use of and passing of JarFile throughout the entire deployment = process with DeployableModule.

Next I plan to fix all the tests = that are now broken, then start plugging in a new Impl of = DeployableModule for Eclipse support and see if we need to tweak = add/remove methods to the interface as I'm not convinced yet that all = the methods currently are sufficient.=A0 This is where the bulk of the = work will be so feel free to help out if interested :).





 =

= --Apple-Mail-14--104589371--