Return-Path: 
 <dev-return-34978-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 78977 invoked from network); 1 Aug 2006 14:42:53 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 1 Aug 2006 14:42:53 -0000
Received: (qmail 10416 invoked by uid 500); 1 Aug 2006 14:42:49 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 10354 invoked by uid 500); 1 Aug 2006 14:42:49 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 10335 invoked by uid 99); 1 Aug 2006 14:42:49 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 07:42:49 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 07:42:47 -0700
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id EDE85410021
	for <dev@geronimo.apache.org>; Tue,  1 Aug 2006 14:40:15 +0000 (GMT)
Message-ID: <23509132.1154443215971.JavaMail.jira@brutus>
Date: Tue, 1 Aug 2006 07:40:15 -0700 (PDT)
From: "Jeff Genender (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (XBEAN-26) [RTC] Nested properties not evaluated
 for named constructor args
In-Reply-To: <26626339.1152920473816.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

    [ http://issues.apache.org/jira/browse/XBEAN-26?page=comments#action_12424879 ] 
            
Jeff Genender commented on XBEAN-26:
------------------------------------

+1...but this looks more like a bug fix..IMHO, this does not require RTC...I would commit and close.

> [RTC] Nested properties not evaluated for named constructor args
> ----------------------------------------------------------------
>
>                 Key: XBEAN-26
>                 URL: http://issues.apache.org/jira/browse/XBEAN-26
>             Project: XBean
>          Issue Type: Bug
>          Components: spring
>            Reporter: Dain Sundstrom
>         Assigned To: Dain Sundstrom
>             Fix For: 2.6
>
>         Attachments: named-constructor-arg-fixes.patch
>
>
> Nested property elements are not evaluated when they are constructor arguments.  For example the following three declarations should be equivalent:
> {code}
>   <s:soup id="soupService" type="French Onion"/>
>   <s:soup id="nestedBean">
>     <s:type>
>       <bean class="java.lang.String">
>         <constructor-arg index="0" value="French Onion"/>
>       </bean>
>     </s:type>
>   </s:soup>
>   <s:soup id="nestedValue">
>     <s:type>
>       <value>French Onion</value>
>     </s:type>
>   </s:soup>
> {code}
> The patch attempts to find a setter for the property and if not located assumes it is type Object instead of just aborting the evaluation.  This means that constructor args without a matching getter or setter can't support our custom map element code because we don't knot the type of the constructor argument at this point in the code.  Fixing that will take a much bigger restructure of the code.
> There are test cases included with the patch. Note there is one new file included with the patch that must be svn added.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira