Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 26318 invoked from network); 31 Aug 2006 21:55:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 31 Aug 2006 21:55:41 -0000 Received: (qmail 13566 invoked by uid 500); 31 Aug 2006 21:55:38 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 13521 invoked by uid 500); 31 Aug 2006 21:55:38 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 13510 invoked by uid 99); 31 Aug 2006 21:55:38 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2006 14:55:38 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of eljotpl@gmail.com designates 64.233.166.176 as permitted sender) Received: from [64.233.166.176] (HELO py-out-1112.google.com) (64.233.166.176) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Aug 2006 14:55:37 -0700 Received: by py-out-1112.google.com with SMTP id x66so1261169pye for ; Thu, 31 Aug 2006 14:55:17 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=auArST5JkvmmE1YjXjwzl1dDOhCOUEfdTHBqLhP+8+bj+IXGfeNqO2gT6SF2M52s0MQ59XJL2uZClHdBsyU1Cb9N1wkAP6XlFEGdoxPQZVqsVuJbW+5+kUmw8Ab3LBKrebu4nWfRgE9umaaQfOPbOsGc7nFrXmE4YxEmhtlGQV4= Received: by 10.35.20.14 with SMTP id x14mr1512348pyi; Thu, 31 Aug 2006 14:55:17 -0700 (PDT) Received: by 10.35.48.10 with HTTP; Thu, 31 Aug 2006 14:55:16 -0700 (PDT) Message-ID: <1b5bfeb50608311455j76636338r12c2b698311381aa@mail.gmail.com> Date: Thu, 31 Aug 2006 23:55:16 +0200 From: "Jacek Laskowski" Reply-To: jacek@laskowski.net.pl Sender: eljotpl@gmail.com To: dev@geronimo.apache.org Subject: Re: Classes in trunk In-Reply-To: <2faaa0980608290013u63eaa0d2jc2e5a5f3f769f543@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2faaa0980608290013u63eaa0d2jc2e5a5f3f769f543@mail.gmail.com> X-Google-Sender-Auth: 4582fd3aa365340d X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 8/29/06, Sergey Elin wrote: > there is a number of class files in trunk. Any reasons for it? Other than there're there for the tests? No. Seriously, there're in trunk as they're simply resources for tests (am I repeating myself?). jlaskowski@dev /cygdrive/c/oss/geronimo/modules/geronimo-tomcat-builder/src/test/resources/deployables/war4/WEB-INF/classes/org/apache/geronimo/tomcat/app $ svn log Servlet1.class ... ------------------------------------------------------------------------ r164651 | jgenender | 2005-04-25 23:09:26 +0200 (Mon, 25 Apr 2005) | 1 line New tomcat-builder ------------------------------------------------------------------------ Jeff added them likely to not have bothered to script their compilation and proper inclusion in the resources directories of these tests (Jeff? Are you reading this? ;-) ). I think you can go and improve it a little. Create a JIRA task and get rid of them. Let's fix it by creating their java sources and let Maven know about the change. Ready to give it a spin? Ask when in trouble. Jacek -- Jacek Laskowski http://www.laskowski.net.pl