geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Blevins <>
Subject Re: Returning to Commit-Then-Review?
Date Wed, 23 Aug 2006 01:56:44 GMT
On Aug 22, 2006, at 4:02 PM, Rodent of Unusual Size wrote:

> Hash: SHA1
> Apache Geronimo has been operating mostly under the
> Review-Then-Commit model for a couple of months now,
> and I think the issues the change was intended to
> highlight have been .. well, highlighted.
> How do people feel about the idea of switching back
> to Commit-Then-Review at this point?

I'd be more inclined to talk about what we want to apply it to and how.

That said, I've stared at this email for an hour after writing the  
above sentence and am still not sure what the answer would be....

Part of me wouldn't mind seeing an RTC process where
  - it's not enforced. meaning we could pull the plug whenever we like
  - your +1 could simply mean you've reviewed it to your satisfaction  
(whatever that means for you) and agree with the change.

Tempted to also throw in "three +1s from any committer other than the  
proposer are sufficient", but if that's going to be a topic of  
debate, I'd rather see it put on hold and the first two items  
implemented first.


> - --
> #ken	P-)}
> Ken Coar, Sanagendamgagwedweinini  http://Ken.Coar.Org/
> Author, developer, opinionist      http://Apache-Server.Com/
> "Millennium hand and shrimp!"
> Version: GnuPG v1.2.4 (MingW32)
> Comment: Using GnuPG with Mozilla -
> iQCVAwUBROuM8prNPMCpn3XdAQJasgP6AmIwS/d8cS12D6ClRmeWAdbtkQIPFVsY
> QvGXkS6/LhrNNKnA+vsKdOOE/dsPa9MaxlhBNqG4qN8Wz+gQMIj6zD5h+u20GG6W
> LBmDilEYctBZtjTZ+WovEfweQbiAX4aRjWi/mClQzAvKIdMEAph4UmwYQy/F5FG0
> anL4nJoStVw=
> =XJ1j

View raw message