geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Dudney <bdud...@apache.org>
Subject Re: Disallow 1.5 on trunk (until its actually supported)?
Date Sun, 20 Aug 2006 20:52:57 GMT
Problem is that the 1.5 jdk does not include the sun orb so compile  
fails, but not till late in the build

+1 from me

-bd-

On Aug 20, 2006, at 11:36 AM, Alan D. Cabrera wrote:

> Jason Dillon wrote:
>> I keep running into problems switching my local jdk (ala setjdk)  
>> from 1.4 to 1.5 and forgetting to switch it back again when making  
>> G builds.
>>
>> I though it would be nice if the build would fail early if I had  
>> the wrong JDK configured.  So, I wroke a require-java-version goal  
>> in a new tools-maven-plugin (in Genesis), which allows the build  
>> to fail early.  It uses Mac OS X-style version suffix tokens (+  
>> and *) to allow selection.
>>
>>     http://geronimo.apache.org/maven/genesis/plugins/tools-maven- 
>> plugin/usage.html
>>
>> I've set it up for GShell which needs 1.5, but I was wondering if  
>> we should configure this goal in trunk and set it to 1.4* so that  
>> if you are using 1.5 it will puke early with a meaningful error.
>>
>> Seems like folks who build with 1.5 run into errors... so maybe  
>> its a good thing to force 1.4?
>>
>> Thoughts?
>>
>> --jason
>>
>>
> Why not just add the following to the POMs?
>
>        <plugins>
>            <plugin>
>                <groupId>org.apache.maven.plugins</groupId>
>                <artifactId>maven-compiler-plugin</artifactId>
>                <configuration>
>                    <source>1.4</source>
>                    <target>1.4</target>
>                </configuration>
>            </plugin>
>        </plugins>
>
>
> Regards,
> Alan
>
>


Mime
View raw message