geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Mulder" <ammul...@alumni.princeton.edu>
Subject Re: Car plugin
Date Tue, 22 Aug 2006 14:51:20 GMT
Ah, I see -- it's that the plugin plan writing causes problems.

In any case, I agree that it would be nice to have a dedicated G 1.1
version of the car-maven-plugin.

Thanks,
    Aaron

On 8/22/06, Guillaume Nodet <gnodet@gmail.com> wrote:
> On 8/22/06, Aaron Mulder <ammulder@alumni.princeton.edu> wrote:
> > On 8/22/06, Guillaume Nodet <gnodet@gmail.com> wrote:
> > > > I think any problem with the deployer can be avoided by specifying the
> > > > correct set of dependencies and configuration info in the project POM
> > > > (to force it to use only 1.1 JARs/CARs and the 1.1 deployer GBean).
> > > > But if any of the kernel/system interfaces changed, that would
> > > > probably stop working.
> > >
> > > Actually, that' s the main problem.
> >
> > I'm not convinced.  If I understand this correctly, you got a problem
> > when the G 1.2 service builder attempted to do something with a G 1.1
> > deployment plan.  I think you can avoid the 1.2 service builder being
> > invoked by listing all the 1.1 dependencies explicitly.  Is that not
> > what's going on?
>
> The problem is very simple.  That processed plan begins with
> <module xmlns="http://geronimo.apache.org/xml/ns/deployment-1.1">
>  <environment xmlns="http://geronimo.apache.org/xml/ns/deployment-1.2">
>
> which is rejected when deployed on G 1.1.
> Btw, it really sounds weird that the plugin process the environment tag, but not
> the module tag...
> My fix is to allow specifying the target geronimo version, so that the plugin
> will build the namespace uri dynamically: URI_PREFIX + 1.2. This works.
>
> What I meant, is that I' m not convinced that the API will never change and
> that a single plugin will be able to handle all versions in the future.
> This is already the case for the schema which are upgraded by default, even
> if no change happen (I do not argue against that, just stating the fact).  But
> if something change, the plugin will need to cope with the difference.
> Is that what we want ?
>
> Also, I think it would be good to be able to release the plugin without having
> to wait for G 1.2 final, so that users can build G 1.1 plugins easily.
>
> >
> > Thanks,
> >      Aaron
> >
> >
> > > > > >>
> > > > > >> Adding a property to specify the target geronimo version
seems to
> > > > > >> do the trick.
> > > > > >> So i can now have:
> > > > > >>
> > > > > >> <module xmlns="http://geronimo.apache.org/xml/ns/deployment-1.1">
> > > > > >>   <environment>
> > > > > >>
> > > > > >> instead of
> > > > > >>
> > > > > >> <module xmlns="http://geronimo.apache.org/xml/ns/deployment-1.1">
> > > > > >>   <environment xmlns="http://geronimo.apache.org/xml/ns/
> > > > > >> deployment-1.2">
> > > > > >>
> > > > > >> Btw, I' m wondering why the PlanProcessorMojo only overrides
the
> > > > > >> environmnet
> > > > > >> tag, and not the module one.
> > > > > >>
> > > > > >>
> > > > > >> On 8/22/06, Jacek Laskowski <jacek@laskowski.net.pl>
wrote:
> > > > > >> > On 8/22/06, Guillaume Nodet <gnodet@gmail.com>
wrote:
> > > > > >> > > I recently experienced some problems [1] when
building
> > > > > >> Geronimo 1.1
> > > > > >> > > plugins using
> > > > > >> > > the car-maven-plugin.
> > > > > >> >
> > > > > >> > I think a solution may be to build the maven plugin
locally from
> > > > > >> 1.1
> > > > > >> > sources and build Geronimo 1.1 then. It seems you've
been trying to
> > > > > >> > run the build online and thus all the deps (the maven
plugin
> > > > > >> > including) is pulled down too. For it's an incompatible
version,
> > > > > >> the
> > > > > >> > build blows up.
> > > > > >> >
> > > > > >> > Just a wild guess, but may be of help. Report back!
;-)
> > > > > >> >
> > > > > >> > Jacek
> > > > > >> >
> > > > > >> > --
> > > > > >> > Jacek Laskowski
> > > > > >> > http://www.laskowski.net.pl
> > > > > >> >
> > > > > >>
> > > > > >>
> > > > > >> --
> > > > > >> Cheers,
> > > > > >> Guillaume Nodet
> > > > > >>
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Cheers,
> > > > > > Guillaume Nodet
> > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Cheers,
> > > Guillaume Nodet
> > >
> >
>
>
> --
> Cheers,
> Guillaume Nodet
>

Mime
View raw message