geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Mulder (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-1869) Percent complete goes over 100% when installing configurations
Date Tue, 01 Aug 2006 18:11:14 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-1869?page=comments#action_12424961 ] 
            
Aaron Mulder commented on GERONIMO-1869:
----------------------------------------

We have yet another problem with this issue, which is that packed artifacts should used the
file size, whereas artifacts that are going to be unpacked should use the size of the contents.

Applied the ZipFile fix and a workaround that uses the unpacked size for UnpackArtifactTypeHandlers
and packed size otherwise to 1.1.

Not applying to trunk because this really ought to be reconsidered in light of GERONIMO-2258
(if we're going to change the way we decide whether to unpack, we should also change when
we do the size calculation so we only do it if we're going to unpack the artifact anyway).

> Percent complete goes over 100% when installing configurations
> --------------------------------------------------------------
>
>                 Key: GERONIMO-1869
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1869
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: core, console
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>            Priority: Critical
>             Fix For: 1.1.x
>
>
> Looks like the UnpackArtifactTypeHandler counts the "uncompressed" bytes, whereas the
% is based on the content size returned by the server for the download (the "compressed" byte
count).
> Probably should use an InputStream between the download stream and the ZIP stream that
performs the count on read(byte[],int,int) and them use that count instead of the uncompressed
count.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message