geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Mulder (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-2258) Abstract/Maven repositories install modules incorrectly
Date Tue, 01 Aug 2006 17:18:14 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2258?page=comments#action_12424938 ] 
            
Aaron Mulder commented on GERONIMO-2258:
----------------------------------------

Fixed in 1.1.1.  Pending a different fix for 1.2.

> Abstract/Maven repositories install modules incorrectly
> -------------------------------------------------------
>
>                 Key: GERONIMO-2258
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2258
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: kernel
>    Affects Versions: 1.1
>            Reporter: Aaron Mulder
>         Assigned To: Aaron Mulder
>             Fix For: 1.2, 1.1.1
>
>
> The repository unpacks a JAR when it installs it only if the Artifact type is "car".
 That is incorrect -- it should unpack any module with META-INF/config.ser (which is the logic
that we use in other places, such as RepositoryConfigurationStore).  This breaks plugins that
don't have the type "car" (such as copying a database pool from server to server).
> The currently handling attempts to be generic by associating a behavior with each file
type, though in practice this is only used for type=car.  In the 1.1 branch, I am going to
put in a workaround to look up the "car" handler any time we find a META-INF/config.ser (a
pretty minimal workaround).
> In trunk, I think we should remove the behavior/type association and instead have a boolean
for whether configurations should be unpacked, or an "ArtifactTypeHandler" property specifically
for configurations and another one for non-configurations.  I don't see any reason to distinguish
based on module type.  Input would be appreciated for the 1.2 resolution.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message