geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacek Laskowski" <ja...@laskowski.net.pl>
Subject Re: Classes in trunk
Date Thu, 31 Aug 2006 21:55:16 GMT
On 8/29/06, Sergey Elin <elinsn@gmail.com> wrote:

> there is a number of class files in trunk. Any reasons for it?

Other than there're there for the tests? No.

Seriously, there're in trunk as they're simply resources for tests (am
I repeating myself?).

jlaskowski@dev /cygdrive/c/oss/geronimo/modules/geronimo-tomcat-builder/src/test/resources/deployables/war4/WEB-INF/classes/org/apache/geronimo/tomcat/app
$ svn log Servlet1.class
...
------------------------------------------------------------------------
r164651 | jgenender | 2005-04-25 23:09:26 +0200 (Mon, 25 Apr 2005) | 1 line

New tomcat-builder
------------------------------------------------------------------------

Jeff added them likely to not have bothered to script their
compilation and proper inclusion in the resources directories of these
tests (Jeff? Are you reading this? ;-) ).

I think you can go and improve it a little. Create a JIRA task and get
rid of them. Let's fix it by creating their java sources and let Maven
know about the change.

Ready to give it a spin? Ask when in trouble.

Jacek

-- 
Jacek Laskowski
http://www.laskowski.net.pl

Mime
View raw message