geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dillon (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-2352) j2ee-builder test deployment modules won't actually deploy
Date Thu, 31 Aug 2006 05:06:23 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2352?page=comments#action_12431784 ] 
            
Jason Dillon commented on GERONIMO-2352:
----------------------------------------

So far looks good.  A few issues...

 * indent of xml files was not consistent
 * new test-deployables module did not inherit from its parent, which added some additional
unneeded config to children
 * some file shave openejb license and not ASL v2
 * groupid/artifactid might not be optimal

I've fixed the formatting and setup the pom to inherit and dropped the unneeded bits.

I think we should change the artifactId's and directory names for the war/ear/ejb/rar bits...
still pending what those will be, but I don't this we want to have files like war-1.2.war
and ear-1.2.ear.

And, I think we don't need to drop each group (1.3 & 1.4) deployables into a separate
groupId.

You also do not need to nor, should, specify the version of the dependency plugin in child
usage, that will get picked up from the parent's pom.

Anyways, all of this is minor... and I only point it out to you for future reference.  I'm
going to massage this patch slightly as mentioned above and then commit.  Can fix up the licenses
afterwards, not sure exactly what to do about this.

> j2ee-builder test deployment modules won't actually deploy
> ----------------------------------------------------------
>
>                 Key: GERONIMO-2352
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2352
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>            Reporter: Bill Dudney
>         Attachments: GERONIMO-2352.bdudney.patch
>
>
> The ear/war/ejb-jar/rar files wont actually deploy to the server.
> I have a partial patch avalible but I'd like to get some discussion going on how to fix
some of the problems, that is happening in the dev list.
> I will post the complete patch here when that discussion is wrapped up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message