geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick McGuire (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-2209) Enable tests (geronimo-activation :: **/MailcapTest.java)
Date Fri, 11 Aug 2006 15:40:14 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2209?page=comments#action_12427545 ] 
            
Rick McGuire commented on GERONIMO-2209:
----------------------------------------

I think it goes beyond just a JDK 1.5 vs. 1.4 issue.  Some JVMs (or some JVM extension) appears
to contain a set of mailcap handlers that are defined in a corresponding META-INF/mailcap
file.  When the unit test loads the definitions using 

        InputStream is = TextPlainHandler.class.getClassLoader().getResourceAsStream("META-INF/mailcap");
        map = new MailcapCommandMap(is);

it appears to be pulling in the JVM resident one rather than the mailcap file contained in
the Geronimo activation module.  This causes the failure because the resolved command handler
is other than the Geronimo provided one.  

I'm not sure this test case can be made completely reliable.  If the intent was to test the
default mappings of the MailcapCommandMap, then there will be inherent conflicts.  If the
intent is just to test the functioning of MailcapCommandMap to load a definition file and
resolve a mime type, then a more appropriate test would be to use a test case resource file
to source the mappings.  I suspect the intent was 1), but this can't really be made reliable
because of JVM differences.  I suggest just disabling this test case. 

> Enable tests (geronimo-activation :: **/MailcapTest.java)
> ---------------------------------------------------------
>
>                 Key: GERONIMO-2209
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2209
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>             Fix For: 1.2
>
>
> A few tests failed in non-obvious ways when run under the m2 build.  Need someone who
knows these tests better to inspect, resolve and enable the test (remove the test exclusions
in the pom).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message