geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gianny Damour (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-2163) WADI Integration for Jetty
Date Mon, 28 Aug 2006 15:26:23 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2163?page=comments#action_12430989 ] 
            
Gianny Damour commented on GERONIMO-2163:
-----------------------------------------

Many thanks David for having ported this patch to the new module layout and improved NamespaceDrivenBuilders
to allow environment modifications.

v4 applies cleanly except for a couple of problems with PlanParsingTest and JettyModuleBuilderTest.
I think that svn was confused somewhere during the diff. For instance, here is a relevant
snip:

"
Index: modules/geronimo-jetty-builder/src/test/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilderTest.java===================================================================---
modules/geronimo-jetty-builder/src/test/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilderTest.java
      (revision 437418)
+++ modules/geronimo-jetty-builder/src/test/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilderTest.java
      (working copy)

<further in the same diff>

-public class JettyModuleBuilderTest extends TestSupport {
+public class PlanParsingTest extends TestSupport {
"

It seems that svn tried to diff JettyModuleBuilderTest and PlanParsingTest :(.

Having said that, it seems that substitution group is not happening for an obscure reason.
After having modified WADIJettyClusteringBuilder to register a namespace conversion via the
following line:

        SchemaConversionUtils.registerNamespaceConversions(
        		Collections.singletonMap("clustering-wadi", new NamespaceElementConverter(WADI_NAMESPACE)));

and added an empty clustering-wadi element to the geronimo-web.xml DD. I still get the following
error:

    Error: Operation failed: xml problem for web app .

        Invalid deployment descriptor: [error: cvc-complex-type.2.4a:
    Expected elements
    'context-root@http://geronimo.apache.org/xml/ns/j2ee/web/jetty-1.2
    clustering@http://geronimo.apache.org/xml/ns/j2ee/application-1.2
    web-container@http://geronimo.apache.org/xml/ns/naming-1.2
    host@http://geronimo.apache.org/xml/ns/j2ee/web/jetty-1.2
    virtual-host@http://geronimo.apache.org/xml/ns/j2ee/web/jetty-1.2
    session-manager@http://geronimo.apache.org/xml/ns/j2ee/web/jetty-1.2
    gbean-ref@http://geronimo.apache.org/xml/ns/naming-1.2
    ejb-ref@http://geronimo.apache.org/xml/ns/naming-1.2
    ejb-local-ref@http://geronimo.apache.org/xml/ns/naming-1.2
    service-ref@http://geronimo.apache.org/xml/ns/naming-1.2
    resource-ref@http://geronimo.apache.org/xml/ns/naming-1.2
    resource-env-ref@http://geronimo.apache.org/xml/ns/naming-1.2
    message-destination@http://geronimo.apache.org/xml/ns/naming-1.2
    security-realm-name@http://geronimo.apache.org/xml/ns/j2ee/web/jetty-1.2
    service@http://geronimo.apache.org/xml/ns/deployment-1.2' instead of
    'clustering-wadi@http://geronimo.apache.org/xml/ns/clustering-wadi-1.2'
    here]

    Descriptor: <xml-fragment
    xmlns:dep="http://geronimo.apache.org/xml/ns/deployment-1.2"
    xmlns:clus="http://geronimo.apache.org/xml/ns/clustering-wadi-1.2">
      <dep:environment>
        <dep:moduleId>
          <dep:groupId>org.codehaus.wadi</dep:groupId>
          <dep:artifactId>wadi-webapp</dep:artifactId>
          <dep:version>2.0M2-SNAPSHOT</dep:version>
          <dep:type>war</dep:type>
        </dep:moduleId>
      </dep:environment>

      <clus:clustering-wadi/>

    </xml-fragment>

This is weird as <clus:clustering-wadi/> should be a valid substitution to clustering@http://geronimo.apache.org/xml/ns/j2ee/application-1.2.
I will investigate further this problem. However, if you do already know the problem, then
please let me know.


> WADI Integration for Jetty
> --------------------------
>
>                 Key: GERONIMO-2163
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2163
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: Clustering
>            Reporter: Gianny Damour
>         Assigned To: Gianny Damour
>            Priority: Minor
>         Attachments: GERONIMO-2163-v3.patch, GERONIMO-2163-v3b.patch, GERONIMO-2163-v4-old.patch,
GERONIMO-2163-v4.patch, geronimo-wadi-integration-preview.patch, geronimo-wadi-integration-RTC.patch,
geronimo.patch, setUpServers.tar.gz, wadi-geronimo-integration-preview.patch, wadi.patch
>
>
> Email sent to the dev@ list.
> Hi,
> I have been working on a second integration attempt of WADI and I am posting here a high-level
description of the current state of progress such that people can jump in.
> At this stage, this is a Jetty only attempt and I do believe that the same approach can
be applied for Tomcat. The current integration provides (very unreliable) HttpSession state
migration. It only works for a single Web-application; more effort is required on the WADI
side to support multiple Web-applications and this will not impact the integration piece of
code. I (more or less successfully) tested the integration with mod_proxy + mod_proxy_balancer
and mod_proxy + mod_rewrite in front of three Geronimo servers running the WADI demo web-app.
> The code changes are:
> * new module to capture some clustering contracts - geronimo-clustering: there Node,
SessionManager, Session and ClusteredInvocation are defined.
> * new module to provide a WADI implementation of the above - geronimo-clustering-wadi;
> * new module to capture clustering builder contracts - geronimo-clustering-builder: there
is only one interesting interface JettyClusteringBuilder. This later defines a couple of methods
to augment the environment of a Web module being built and add clustering specific GBeans;
> * new module to provide a WADI implementation of the above - Geronimo-clustering-builder-wadi;
and
> * geronimo-jetty-builder and geronimo-jetty are impacted to hook in clustering. These
two modules depend on geronimo-clustering and geronimo-clustering-builder and not on WADI
specific modules.
> Two new modules are added:
> * jetty-clustering- wadi: this module defines default WADI GBeans such as Dispatcher,
ReplicationManagerFactory, BackingStrategyFactory et cetera; and
> * jetty-clustering-builder-wadi: this module defines a builder to process Jetty DD and
add various GBeans to the module being built.
> I think that the implementation is flexible enough to plug in another clustering implementation
such as Kache.
> As a matter of fact, there are some severe reliability (e.g. locking issues) and integration
(only one Web-app can be clustered) issues, which need to be fixed. So, this work is not yet
ready to be RTC voted. Having said that, I have opened a JIRA such that people can have a
look to the integration.
> Thanks,
> Gianny

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message