Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (asf.osuosl.org: domain of ammulder@gmail.com designates
 66.249.92.169 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=qepnz7vqKcVSqhGWL3s/J0a+NSVb8kz354y8vy8j/gFDHarRKkFWKuTu1hbNj8OuxP4tN4Dpxd76ac5snYJHU5zJ9Xyd6M6YLnzzde+lxtfHmkIjnh/XFI8c/9UgvO/5omzdxQoC8oswEvZpaH1oIRb8iNc5VF+oJc4UpHSwbYs=
Message-ID: <74e15baa0607171658h205c43b1r285fdaa41d02fde4@mail.gmail.com>
Date: Mon, 17 Jul 2006 19:58:53 -0400
From: "Aaron Mulder" <ammulder@alumni.princeton.edu>
Sender: ammulder@gmail.com
To: dev@geronimo.apache.org
Subject: Re: Remove GeronimoExecutor?
In-Reply-To: <E8D68E33-A4F8-4EBE-9F39-D4E8C77D82A7@iq80.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E8D68E33-A4F8-4EBE-9F39-D4E8C77D82A7@iq80.com>

There's a method somewhere (perhaps ThreadPool) that takes a name and
a runnable and is useful in that the console can then show what kind
of work is being done with the thread pool -- particularly useful for
things like the default thread pool which can be used all over the
place.  I don't really fancy removing that.  But I'm fine with
removing the interface below.

Thanks,
    Aaron

On 7/17/06, Dain Sundstrom <dain@iq80.com> wrote:
> Can we remove the interface GeronimoExecutor from Geronimo or at the
> very least have no services use it?  For those of you whom are not
> aware of this interface, it adds a getName and getObjectName
> interface to an Executor.  Here is the code:
>
> public interface GeronimoExecutor extends Executor,
> org.apache.geronimo.system.threads.ThreadPool {
>      /**
>       * Gets a human-readable name identifying this object.
>       */
>      String getName();
>
>      /**
>       * Gets the unique name of this object.  The object name must
> comply with
>       * the ObjectName specification in the JMX specification.
>       *
>       * @return the unique name of this object within the server
>       */
>      String getObjectName();
> }
>
> I searched the code base and there isn't a single use of the getName
> and getObjectName methods.  The problem is the Work manager needs one
> of these in the constructor, but it only uses the execute method
> declared on in the Executor and ThreadPool interfaces.  This means
> that if you want to use the work manager you must take both the
> geronimo-core and geronimo-system jars to get the GeronimoExecutor
> and ThreadPool interfaces respectively.
>
> So can we please please please remove this interface and just use
> Executor?
>
> I'd like to do this in both 1.2 and 1.1.1.
>
> -dain
>