Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 66496 invoked from network); 3 Jul 2006 06:50:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 Jul 2006 06:50:18 -0000 Received: (qmail 60049 invoked by uid 500); 3 Jul 2006 06:50:16 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 59996 invoked by uid 500); 3 Jul 2006 06:50:15 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 59985 invoked by uid 99); 3 Jul 2006 06:50:15 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jul 2006 23:50:15 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Jul 2006 23:50:14 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9B930410336 for ; Mon, 3 Jul 2006 06:48:30 +0000 (GMT) Message-ID: <24813570.1151909310607.JavaMail.jira@brutus> Date: Mon, 3 Jul 2006 06:48:30 +0000 (GMT+00:00) From: "John Sisson (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml In-Reply-To: <14126131.1151729310788.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/GERONIMO-2161?page=comments#action_12418906 ] John Sisson commented on GERONIMO-2161: --------------------------------------- +1 : applied patch and tested build. Due to xmlbeans issue (which is a separate problem not caused by this patch) It took a number of build attempts using Jason's script he shared with me on IRC: {noformat} #!/bin/sh # Drop all existing repo state rm -rf ~/.m2/repository # Clean, since mvn clean won't work everytime because of chicken-egg plugins find . -name target -type d -exec rm -rf \{\} \; # Build the G modules - 13 times to get around xmlbeans crap for x in 1 2 3 4 5 6 7 8 9 10 11 12 13; do mvn -Dstage=bootstrap -Dmaven.test.skip=true done # Build OpenEJB - 3 times to get around xmlbeans crap ( cd openejb2/modules; mvn clean; mvn install; mvn install; mvn install ) # Build G apps, config and assembly mvn -Dstage=assemble -Dmaven.test.skip=true {noformat} > [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml > ----------------------------------------------------------------------- > > Key: GERONIMO-2161 > URL: http://issues.apache.org/jira/browse/GERONIMO-2161 > Project: Geronimo > Type: Task > Security: public(Regular issues) > Components: buildsystem > Reporter: Jason Dillon > Assignee: Jason Dillon > Fix For: 1.2 > Attachments: GERONIMO-2161-configs-v1.1.sub.patch, GERONIMO-2161-v1.patch, GERONIMO-2161-v2.patch > > As I have mentioned before, I believe we should remove the Geronimo modules that are currently listed in the root pom.xml: > This reduces the configuration of the pom by *~500 lines*. > Modules that reference these as dependencies will need their pom's adjusted to include ${pom.version} and car for the configs. But in many places version already exists with the ${geronimoVersion} property... which kinda negates the purpose of the dependencyManagement section anyways. > I believe that it is more work to keep track of every module in the root pom than it is to specify the additonal elements (mostly just ${pom.version}) in child poms. There is no additional maintenance, as the new elements never need to be changed. > Net effect if this change is less configuration to maintain and thus a less brittle build that can adapt to change easier. > Specifically these should be removed: > {code:xml} > > org.apache.geronimo.modules > ge-activemq-rar > ${geronimoVersion} > rar > > > org.apache.geronimo.modules > geronimo-activation > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-client > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-client-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-common > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-connector > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-connector-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-converter > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-core > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-deploy-config > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-deploy-jsr88 > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-deploy-tool > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-deployment > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-derby > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-directory > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-javamail-transport > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-j2ee > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-j2ee-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-j2ee-schema > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-kernel > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-jetty > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-jetty-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-jmx-remoting > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-mail > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-management > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-naming > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-naming-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-security > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-security-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-service-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-system > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-test-ddbean > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-timer > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-tomcat > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-tomcat-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-transaction > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-upgrade > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-util > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-web-builder > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-webservices > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-axis > ${geronimoVersion} > > > org.apache.geronimo.modules > geronimo-axis-builder > ${geronimoVersion} > > > org.apache.geronimo.configs > activemq > car > ${geronimoVersion} > > > org.apache.geronimo.configs > activemq-broker > car > ${geronimoVersion} > > > org.apache.geronimo.configs > axis > car > ${geronimoVersion} > > > org.apache.geronimo.configs > axis-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > client > car > ${geronimoVersion} > > > org.apache.geronimo.configs > client-corba > car > ${geronimoVersion} > > > org.apache.geronimo.configs > client-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > client-security > car > ${geronimoVersion} > > > org.apache.geronimo.configs > client-system > car > ${geronimoVersion} > > > org.apache.geronimo.configs > console-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > console-tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > daytrader-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > daytrader-tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > directory > car > ${geronimoVersion} > > > org.apache.geronimo.configs > geronimo-gbean-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > hot-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > j2ee-corba > car > ${geronimoVersion} > > > org.apache.geronimo.configs > j2ee-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > j2ee-security > car > ${geronimoVersion} > > > org.apache.geronimo.configs > j2ee-server > car > ${geronimoVersion} > > > org.apache.geronimo.configs > j2ee-system > car > ${geronimoVersion} > > > org.apache.geronimo.configs > javamail > car > ${geronimoVersion} > > > org.apache.geronimo.configs > jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > jetty-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > jsp-examples-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > jsp-examples-tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > ldap-demo-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > ldap-demo-tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > ldap-realm > car > ${geronimoVersion} > > > org.apache.geronimo.configs > online-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > openejb > car > ${geronimoVersion} > > > org.apache.geronimo.configs > openejb-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > project.properties > car > ${geronimoVersion} > > > org.apache.geronimo.configs > remote-deploy-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > remote-deploy-tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > rmi-naming > car > ${geronimoVersion} > > > org.apache.geronimo.configs > servlets-examples-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > servlets-examples-tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > sharedlib > car > ${geronimoVersion} > > > org.apache.geronimo.configs > shutdown > car > ${geronimoVersion} > > > org.apache.geronimo.configs > system-database > car > ${geronimoVersion} > > > org.apache.geronimo.configs > tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > tomcat-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > uddi-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > uddi-tomcat > car > ${geronimoVersion} > > > org.apache.geronimo.configs > unavailable-client-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > unavailable-ejb-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > unavailable-webservices-deployer > car > ${geronimoVersion} > > > org.apache.geronimo.configs > upgrade > car > ${geronimoVersion} > > > org.apache.geronimo.configs > upgrade-cli > car > ${geronimoVersion} > > > org.apache.geronimo.configs > welcome-jetty > car > ${geronimoVersion} > > > org.apache.geronimo.configs > welcome-tomcat > car > ${geronimoVersion} > > {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira