geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <david_jen...@yahoo.com>
Subject Re: [m2 build] Update about custom assembly usage
Date Tue, 18 Jul 2006 00:12:28 GMT

On Jul 15, 2006, at 12:28 PM, Jason Dillon wrote:

> m1, m2 or ant... the timer tests are not written in such a way that  
> they will always pass.  They are heavily dependent on running on a  
> healthy/speedy box or they will start to fail with random errors.
>
> These tests run fine for me, but fail for Prasad.  The failures are  
> all due to Thread.sleep() returning before the expected number of  
> timer invocations have been executed.
>
> They need to be augmented to remove the window for random failures.

After I wrote the tests I made many changes to make them pass on more  
machines than just mine.  I'd love to know how to make them  
independent of machine load/speed.  Do you have any concrete  
suggestions on how to do this?

thanks
david jencks

>
> --jason
>
>
> On Jul 15, 2006, at 3:59 AM, anita kulshreshtha wrote:
>
>>    IIRC these tests have been running successfully (in M1) for more
>> than a year on all kinds of machines.
>>
>> Thanks
>> Anita
>>
>> --- Jason Dillon <jason@planet57.com> wrote:
>>
>>> I did not turn them off... I just added a Jira to remind us that
>>> these tests need to be fixed.
>>>
>>> --jason
>>>
>>>
>>> On Jul 14, 2006, at 8:43 PM, Prasad Kashyap wrote:
>>>
>>>> The timer tests failed. Jason, I thought you pulled them out late
>>> last
>>>> night after our discussion.
>>>>
>>>> Cheers
>>>> Prasad
>>>>
>>>> On 7/14/06, Prasad Kashyap <goyathlay.geronimo@gmail.com> wrote:
>>>>> The bootstrap on linux first failed a test in the security module.
>>> I
>>>>> ran the build inside the security module. It passed successfully.
>>>>>
>>>>> Then I ran bootstrap again. It failed while transferring an
>>> artifact.
>>>>>
>>>>> Now I'm running mvn from top level. This is running.
>>>>>
>>>>>
>>>>> Keeping my fingers crossed
>>>>> Prasad
>>>>>
>>>>> On 7/14/06, Prasad Kashyap <goyathlay.geronimo@gmail.com> wrote:
>>>>>> I tried the latest changes on Windows and it builds the assembly
>>>
>>>>> fine.
>>>>>> I even ran the jetty binary successfully.
>>>>>>
>>>>>> Jason, I also tried commenting out a few builders from the
>>>>>> dependencies list and it still worked fine. So I guess we can
>>> prune
>>>>>> the deps list to remove the redudant ones.
>>>>>>
>>>>>> A full extract and bootstrap on Linux is running.
>>>>>>
>>>>>> Cheers
>>>>>> Prasad
>>>>>>
>>>>>> On 7/14/06, Jason Dillon <jason@planet57.com> wrote:
>>>>>>> It looks like the Maven 2 peeps are not going to be able to
>>>>> take in
>>>>>>> our patches to apply to the assembly plugin, which provides
>>>>> mappers
>>>>>>> and some includes/excludes to unpack and a permission related
>>>
>>>>> fix to
>>>>>>> files/file element processing.
>>>>>>>
>>>>>>> I believe that those changes will eventually make it in, but
>>>>> for now
>>>>>>> to get around the need Prasad and I talked about using the
>>>>> dependency
>>>>>>> plugin and the antrun plugin to perform the needed
>>>>> "flattening" of
>>>>>>> the schema files for the /schema/* in the assembly.
>>>>>>>
>>>>>>> I've implemented this already for the geronimo-jetty-j2ee
>>>>> assembly in
>>>>>>> the svkmerge/m2migration branch.
>>>>>>>
>>>>>>> It appears to function as expected.  I've disabled the
>>> remaining
>>>>>>> assemblies which have not yet been converted.  Once they have
>>>
>>>>> been
>>>>>>> converted they will be re-enabled.
>>>>>>>
>>>>>>> Note, we are still using car:installConfigs... but we no
>>>>> longer need
>>>>>>> to have MASSEMBLY-45 or MASSEMBLY-127 applied to a custom 2.2-
>>>>>>> SNAPSHOT version of the maven-assembly-plugin to build out
>>>>> assemblies.
>>>>>>>
>>>>>>> The full conversation is here if anyone is interested:
>>>>>>>
>>>>>>>      http://uwyn.com/drone/log/bevinbot/geronimo/20060714
>>>>>>>
>>>>>>> Starts with '19:53 <jdillon> any thoughts on using dependency
>>> +
>>>>>>> antrun to setup the right bits and then use the 2.1 assembly
>>>>> plugin?'
>>>>>>> --jason
>>>>>>>
>>>>>>
>>>>>
>>>
>>>
>>
>>
>> __________________________________________________
>> Do You Yahoo!?
>> Tired of spam?  Yahoo! Mail has the best spam protection around
>> http://mail.yahoo.com
>


Mime
View raw message