geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
Date Sun, 02 Jul 2006 08:10:21 GMT
> 1/ Why has the version tag been added? Doesn't M2 take care of it?
>
>         <dependency>
>             <groupId>org.apache.geronimo.modules</groupId>
>             <artifactId>geronimo-security-builder</artifactId>
> +            <version>${pom.version}</version>
>         </dependency>

m2 dose not take care of this.

internal modules IMO should be defined with this additional version  
element to avoid needing to insert a dependencyManagement element in  
the root pom.

IMO putting it here is easier to maintain and manage than to force  
more than one file to be used to control the version.

This is only for internal dependencies that share the same $ 
{pom.version}.

NOTE: Before I even started working on this the m2 configuration was  
already misusing the dependencyManagement section, but having all  
issues redefine the same property-based version.


> 2/ Could the syntax of application names be changed to
>
> <name>Geronimo Applications :: The Magic G Ball :: WAR</name>
>
> rather than
>
> <name>Geronimo Applications, The Magic G Ball :: WAR</name>
>
> to be aligned with
>
> <name>Geronimo Applications :: The Magic G Ball</name>

Yes that could be the syntax, but, once restart the restructure to  
better organize modules for the m2 build, the use of the ' :: '  
separator gets quite out of hand.  There will be several layers of  
nesting.  To help this naming system scale only one (max two ::  
should be used), otherwise the names get quite out of hand.

They were already out of hand and so I re-applied to original naming  
scheme that I setup for the m1 modules way way back.


> 3/ Why has this been excluded?
>
> +++ modules/directory/pom.xml	(working copy)
> ...
> +            <exclusions>
> +                <exclusion>
> +                    <groupId>commons-test</groupId>
> +                    <artifactId>commons-test</artifactId>
> +                </exclusion>
> +            </exclusions>

As a measure to get this puppy to build ;-)

Where is this dependency?  Where is its project?  Where is the  
version to be used?

If it is actually needed then we need an official build for it... and  
a version in a well know repository.

FYI, there are a bunch of whacked dependencies throughout the build.   
It is going to take many more RTC to get all of that resolved.

--jason

Mime
View raw message