geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Mulder (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-2225) The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
Date Tue, 25 Jul 2006 14:58:14 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2225?page=comments#action_12423354 ] 
            
Aaron Mulder commented on GERONIMO-2225:
----------------------------------------

Anita, I didn't understand the bulk of your last comment.  What are the 3 artifacts generated
by the daytrader config?  Does the Maven car plugin process the geronimo-plugin.xml "at the
right moment" or do we attach some Ant script to one of the build stages to do the copy and
filtering or what?

Jason, what part of geronimo-plugin.xml needs to change?  Is it just the substitution variables?
 If so, if you tell me what the correct variable names should be then I'll change all the
geronimo-plugin.xml files in the branch.

Anita, it sounds like you're saying we should have src/conf/geronimo-plugin.xml (M1) and src/conf2/geronimo-plugin.xml
(M2).  I don't think that's necessary.  Let's just switch the plugin files to M2 in place.
 It will mean we don't generate working plugins for the M1 build, but that's OK, when we merge
the branch back to trunk we'll be committed to M2 and I don't think we need to be able to
generate plugins both ways (we're certainly not going to post 2 sets of plugins to the repository,
one built with M1 and one build with M2).

If there was strong opposition to the plugins-for-M2-only approach I could just hardcode all
the values for now and put back the variables after M1 has gone away, but that seems pretty
silly.

> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs
> -------------------------------------------------------------------------
>
>                 Key: GERONIMO-2225
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2225
>             Project: Geronimo
>          Issue Type: Sub-task
>      Security Level: public(Regular issues) 
>          Components: buildsystem
>    Affects Versions: 1.2
>            Reporter: Jason Dillon
>         Assigned To: Jason Dillon
>            Priority: Blocker
>             Fix For: 1.2
>
>
> The M2 build no longer inserts META-INF/geronimo-plugin.xml into the CARs that have src/conf/geronimo-plugin.xml.
 There was handling for this in the M1 build (e.g. for the welcome app and other examples).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message