geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-2153) Global JNDI
Date Tue, 04 Jul 2006 23:41:30 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2153?page=comments#action_12419191 ] 

David Jencks commented on GERONIMO-2153:
----------------------------------------

I apologize for taking so long to get to reviewing this.

This has some good elements but also quite a few problems.  Here are a few suggestions.

1. The bindingGBeans do not need to know the name of the gbean they are getting something
to bind into jndi from, they need a reference to it.  Similarly they do not need to bind a
naming Reference, they can bind the object itself.  For instance, the connector binding gbean
can do something like this:

private final ManagedConnectionFactoryWrapper managedConnectionFactoryWrapper; // this is
the reference to the gbean that gives us the connection factory to bind

...

//now it's time to bind the connection factory

Object connectionFactory = managedConnectionFactoryWrapper.$getResource();
globalContext.bind(jndiName, connectionFactory);

This is also going to affect how the builders set up the binding gbeans: they know the name
of the appropriate gbean such as managedConnectionFactoryWrapper, since they just created
it, so they need to use that name to set the reference pattern in the binding gbean.  The
binding gbean will then get (a proxy to) the "real" gbean that it can use as outlined above.

2. I don't see an implementation of a writable thread safe jndi Context, as dain pointed out
you would need.

3. The zip file consists almost entirely of irrelevant files and the actual source files do
not all appear to be in the geronimo project structure.  This makes it extremely hard to figure
out what to look at.

4. Some of the code modifications (such as to ServiceConfigBuilder) appear to be test cases
rather than production code.  It will be a lot easier to evaluate your work if you keep test
cases and production code clearly separated as is done in typical maven projects.

5. I think you will need to redo the openejb work after dain's reintegration of his container
rewrite.

Thanks!  Let us know if you have any questions about this.

> Global JNDI
> -----------
>
>          Key: GERONIMO-2153
>          URL: http://issues.apache.org/jira/browse/GERONIMO-2153
>      Project: Geronimo
>         Type: New Feature
>     Security: public(Regular issues) 
>   Components: naming
>     Versions: 1.2
>     Reporter: Krishnakumar B
>  Attachments: jndi-project.zip
>
> Implementing Global JNDI for server
> Requirements
> * Non -persistent
> * Read/Write
> * Bindings to JNDI/COS-NAMING/JAXR
> * Can bind RA,EJB,GBEAN,Any object

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message