geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Jencks <david_jen...@yahoo.com>
Subject Re: [jira] Commented: (GERONIMO-2161) [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
Date Sun, 02 Jul 2006 08:00:37 GMT

On Jul 2, 2006, at 12:24 AM, Jacek Laskowski wrote:

> On 7/2/06, Jason Dillon (JIRA) <dev@geronimo.apache.org> wrote:
>
>> > [RTC] Remove Geronimo modules from dependencyManagement in root  
>> pom.xml
>> >  
>> --------------------------------------------------------------------- 
>> --
>> >
>> >          Key: GERONIMO-2161
>> >          URL: http://issues.apache.org/jira/browse/GERONIMO-2161
>> >      Project: Geronimo
>> >         Type: Task
>> >     Security: public(Regular issues)
>> >   Components: buildsystem
>> >     Reporter: Jason Dillon
>> >     Assignee: Jason Dillon
>> >      Fix For: 1.2
>> >  Attachments: GERONIMO-2161-v1.patch
>
> I've got questions about the patch. Appreciate comments.
>
> 1/ Why has the version tag been added? Doesn't M2 take care of it?
>
>         <dependency>
>             <groupId>org.apache.geronimo.modules</groupId>
>             <artifactId>geronimo-security-builder</artifactId>
> +            <version>${pom.version}</version>
>         </dependency>
>

This was the main point of the patch, as discussed on the dev list  
and in the patch description: to remove geronimo dependencies from  
dependencyManagement and instead include this version tag wherever  
they are used.  I'm a bit surprised by this idea but jason has worked  
on many more m2 projects than I and I'm happy to believe him that  
this will make our life easier.

thanks
david jencks

> 2/ Could the syntax of application names be changed to
>
> <name>Geronimo Applications :: The Magic G Ball :: WAR</name>
>
> rather than
>
> <name>Geronimo Applications, The Magic G Ball :: WAR</name>
>
> to be aligned with
>
> <name>Geronimo Applications :: The Magic G Ball</name>
>
> 3/ Why has this been excluded?
>
> +++ modules/directory/pom.xml	(working copy)
> ...
> +            <exclusions>
> +                <exclusion>
> +                    <groupId>commons-test</groupId>
> +                    <artifactId>commons-test</artifactId>
> +                </exclusion>
> +            </exclusions>
>
>
> Jacek
>
> -- 
> Jacek Laskowski
> http://www.laskowski.net.pl


Mime
View raw message