geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevan Miller (JIRA)" <...@geronimo.apache.org>
Subject [jira] Commented: (GERONIMO-2167) deployer.jar not cleaning up properly during redeploy and undeploy
Date Mon, 17 Jul 2006 10:28:14 GMT
    [ http://issues.apache.org/jira/browse/GERONIMO-2167?page=comments#action_12421573 ] 
            
Kevan Miller commented on GERONIMO-2167:
----------------------------------------

Leonard, thanks for the source.

I'm certain that the following line of code from ContextListener.contextInitialized() is at
the root of your problem:

   InputStreamReader in = new InputStreamReader(getClass().getClassLoader().getResourceAsStream("db.sql"));

db.sql is the "file" that's being locked by Windows. Right now, your contextDestroyed() method
is not doing anything. I'd prefer to see it closing your HSQL connection and insuring that
the above InputStreamReader has been closed. I'm pretty confident that if you close the above
InputStream, undeploy will work properly...

I'm leaving the jira open a bit longer, it's possible that we could/should avoid this situation.
Geronimo should be able to deploy/undeploy an app, even if it's not "well-behaved". I'm going
to think about this...


> deployer.jar not cleaning up properly during redeploy and undeploy
> ------------------------------------------------------------------
>
>                 Key: GERONIMO-2167
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-2167
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 1.1
>         Environment: Win32/XP SP1
> Sun JDK 1.5_06
>            Reporter: Leonard Wu
>         Assigned To: Kevan Miller
>             Fix For: 1.1.1
>
>         Attachments: dwr-demo.war, jw-0620-dwr.zip
>
>
> deployment using deploy.jar doesn't appear to clean up correctly.
> first deploy always works. subsequent re-deploy and un-deploy are problematic.
> following illustrates the full sequence of events as i had encountered:
> ------------------------------------------
> D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar deployer.ja
> r --user system --password manager deploy D:/work/SERVER/dwr-demo.war
>     Deployed littleoldme/dwrdemo/1.1/war @ http://vaio:8080/dwr-demo
> D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar deployer.ja
> r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war
>     No ModuleID or TargetModuleID provided.  Attempting to guess based
>     on the content of the archive.
>     Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war'
>     Stopped littleoldme/dwrdemo/1.1/war
>     Unloaded littleoldme/dwrdemo/1.1/war
>     Uninstalled littleoldme/dwrdemo/1.1/war
>     Deployed littleoldme/dwrdemo/1.1/war
>     Started littleoldme/dwrdemo/1.1/war
>     Redeployed littleoldme/dwrdemo/1.1/war
> D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar deployer.ja
> r --user system --password manager redeploy D:/work/SERVER/dwr-demo.war
>     No ModuleID or TargetModuleID provided.  Attempting to guess based
>     on the content of the archive.
>     Attempting to use ModuleID 'littleoldme/dwrdemo/1.1/war'
>     Stopped littleoldme/dwrdemo/1.1/war
>     Unloaded littleoldme/dwrdemo/1.1/war
>     Uninstalled littleoldme/dwrdemo/1.1/war
>     Error: Operation failed:
>     org.apache.geronimo.kernel.config.ConfigurationAlreadyExistsException:
>     Configuration already exists: littleoldme/dwrdemo/1.1/war
>         Configuration already exists: littleoldme/dwrdemo/1.1/war
> D:\work\SERVER\geronimo-1.1\bin>c:\JDK\jdk1.5.0_06\bin\java.exe -jar deployer.ja
> r --user system --password manager undeploy littleoldme/dwrdemo/1.1/war
>     Error: littleoldme/dwrdemo/1.1/war does not appear to be a the name
>     of a module available on the selected server. Perhaps it has already
>     been stopped or undeployed?  If you're trying to specify a
>     TargetModuleID, use the syntax TargetName|ModuleName instead. If
>     you're not sure what's running, try the list-modules command.
> ------------------------------------------
> While in this broken state, i'm able to recover by manually removing the ${geronimo}/repository/littleoldme
directory and removing the one line in ${geronimo}/var/config/config.xml that says
> <module load="false" name="littleoldme/dwrdemo/1.1/war"/>
> However, this only gets me to a fresh beginning, and then the whole sequence starts again
as I repeat (re/un)deploying.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message