Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <9350968.1149284551013.JavaMail.jira@brutus>
Date: Fri, 2 Jun 2006 21:42:31 +0000 (GMT+00:00)
From: "David Jencks (JIRA)" <dev@geronimo.apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Closed: (GERONIMO-2077) Under load receiving Null Pointer
 Exceptions in CMPGetter
In-Reply-To: <22446369.1149284070254.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/GERONIMO-2077?page=all ]
     
David Jencks closed GERONIMO-2077:
----------------------------------

    Resolution: Fixed

Fixed in openejb rev 2662.

Moral of story: be sure to clean up pool entries BEFORE returning them to the pool, not after they have been checked out and put in use by another thread.

As a warning to others, here's the change:

--- src/java/org/openejb/entity/EntityInstanceContext.java      (revision 2660)
+++ src/java/org/openejb/entity/EntityInstanceContext.java      (working copy)
@@ -160,6 +160,8 @@
                 if (id != null) {
                     ejbPassivate();
                 }
+                loaded = false;
+                setTransactionContext(null);
                 if (pool != null) {
                     pool.release(this);
                 }
            }
        } catch (Throwable t) {
            // problem passivating instance - discard it and throw the problem (will cause rollback)
            if (pool != null) {
                pool.remove(this);
            }
            throw t;
-        } finally {
-            loaded = false;
-            setTransactionContext(null);
         }
     }                                                                                                                                                                                                             

> Under load receiving Null Pointer Exceptions in CMPGetter
> ---------------------------------------------------------
>
>          Key: GERONIMO-2077
>          URL: http://issues.apache.org/jira/browse/GERONIMO-2077
>      Project: Geronimo
>         Type: Bug
>     Security: public(Regular issues) 
>     Reporter: Matt Hogstrom
>     Assignee: David Jencks
>     Priority: Blocker
>      Fix For: 1.1

>
> When running DayTrader EJB primitives there are some periodic exceptions being thrown in CMPGetter.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira