Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Message-ID: <29365583.1149573030171.JavaMail.jira@brutus>
Date: Tue, 6 Jun 2006 05:50:30 +0000 (GMT+00:00)
From: "David Jencks (JIRA)" <dev@geronimo.apache.org>
To: dev@geronimo.apache.org
Subject: [jira] Commented: (GERONIMO-2071) Move Geronimo build to M2 (new
 1.2 trunk)
In-Reply-To: <25328623.1149089494975.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/GERONIMO-2071?page=comments#action_12414914 ] 

David Jencks commented on GERONIMO-2071:
----------------------------------------

I've looked at the deployment-plugin.patch and most of it looks good.  However I'm confused by the VelocityFilter class since it uses JellyContext which I would expect is unavailable in m2.  Have you actually used velocity filtering in this plugin?  I would actually expect this to move to the assembly plugin, IIRC in m1 it was used during unpacking to replace e.g config.xml with a filtered version.  

Also I don't see any content in the site or test.  Is there some?

i've updated some comments, copyright dates, and such, so if you can advise on whether these parts should remain I'll prune the patch and put it up for a vote.

> Move Geronimo build to M2 (new 1.2 trunk)
> -----------------------------------------
>
>          Key: GERONIMO-2071
>          URL: http://issues.apache.org/jira/browse/GERONIMO-2071
>      Project: Geronimo
>         Type: New Feature
>     Security: public(Regular issues) 
>   Components: buildsystem
>     Versions: 1.2
>     Reporter: Prasad Kashyap
>     Assignee: Jacek Laskowski
>      Fix For: 1.2
>  Attachments: applications.patch, applications.patch.zip, configs.log, configs.patch, deploy-tool.patch, deploy-tool.patch, deployment-plugin.patch, deployment-plugin.patch, geronimo.patch, geronimo.patch, geronimo.patch, m2-plugins.patch, modules.patch, modules.patch, mvn.log, openejb.log, openejb.patch, openejb.patch, openejb.patch, openejb.patch, openejb.patch, pom.xml, pom.xml
>
> A lot of work for moving Geronimo build to M2 was done under G-851. (http://issues.apache.org/jira/browse/GERONIMO-851) 
> The old trunk was renamed as dead-1.2. The new trunk was created from 1.1 and hence the migration work needs to be done here again. This JIRA will seek to consolidate the work that was done under G-851 and all it's subtasks. 
> The patch(es) here will be submitted under the RTC guidelines. Future patches for migration will have to be applied on top of this one. This patch will contain the parent pom, modules, openejb, configs, m2-plugins
> Any issues/concerns about migrating some pieces are well documented in G-851 with links to dev list archives.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira