From dev-return-30390-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org Fri Jun 02 13:28:33 2006 Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 23124 invoked from network); 2 Jun 2006 13:28:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 Jun 2006 13:28:32 -0000 Received: (qmail 48486 invoked by uid 500); 2 Jun 2006 13:28:27 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 48313 invoked by uid 500); 2 Jun 2006 13:28:26 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 48302 invoked by uid 99); 2 Jun 2006 13:28:26 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2006 06:28:26 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jun 2006 06:28:24 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 333B47141E4 for ; Fri, 2 Jun 2006 13:27:30 +0000 (GMT) Message-ID: <19562522.1149254850185.JavaMail.jira@brutus> Date: Fri, 2 Jun 2006 13:27:30 +0000 (GMT+00:00) From: "Aaron Mulder (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Resolved: (GERONIMO-1849) Attribute Manager broken WRT Reference In-Reply-To: <71207472.1145050620188.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/GERONIMO-1849?page=all ] Aaron Mulder resolved GERONIMO-1849: ------------------------------------ Resolution: Fixed Assign To: Aaron Mulder I think we fixed the most important parts of this (removing the junk text from the XML file, making the schema match the file, and validating on load). It is still not possible to fully recreate an abstract name from the elements provided, but "knock on wood" they should be enough to uniquely identify a target. In the future as we review the syntax for patterns and object references in general, we'll just have to remember to review the config.xml syntax accordingly. > Attribute Manager broken WRT Reference > -------------------------------------- > > Key: GERONIMO-1849 > URL: http://issues.apache.org/jira/browse/GERONIMO-1849 > Project: Geronimo > Type: Bug > Security: public(Regular issues) > Components: kernel > Versions: 1.1 > Reporter: Aaron Mulder > Assignee: Aaron Mulder > Priority: Blocker > Fix For: 1.1 > > Discovered for a new GBean generated at runtime with a reference. For a reference to ServerInfo (a single-valued reference, which can use the exact abstract name of the target), you get this: > AbstractName used as the value of the reference: > geronimo/j2ee-system/1.1-SNAPSHOT/car?ServiceModule=geronimo/j2ee-system/1.1-SNAPSHOT/car,j2eeType=GBean,name=ServerInfo > Reference to ServerInfo written into the GBean definition in config.xml: > > > geronimo > j2ee-system > 1.1-SNAPSHOT > car > ServerInfo > geronimo/j2ee-system/1.1-SNAPSHOT/car?ServiceModule=geronimo/j2ee-system/1.1-SNAPSHOT/car,j2eeType=GBean,name=ServerInfo# > > Note these things: > - The AbstractNameQuery is written as plain text after the with a # on the end > - The pattern chunks do not hold the ServiceModule (though it could be calculated) or j2eeType (which would just be lost), so they cannot be used to reconstruct the full AbstractName / AbstractNameQuery / Pattern > - The code also looks for a "module" in the AbstractName to write a element in the pattern, but there is not "module" in the AbstractName in question (should that be the ServiceModule?) > - Many abstract names hold significantly more components than the ServiceName does due to JSR-77 requirements (application name, parent component name, parent component type, etc.), so it's not clear that any hardcoded set of elements can capture the variety of possible abstract names > - The schema at modules/system/src/schema/local-attribute.xsd bears little relation to the syntax currently used in the generated config.xml file, which is not validated when written or read > To reproduce this, start Geronimo, go to the "Keystores" portlet in the console, click "New Keystore", enter a file name and password, submit it, and wait a few seconds for it to be written to config.xml (there will be a new FileKeystoreInstance GBean in the j2ee-security configuration). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira