geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hiram Chirino" <hi...@hiramchirino.com>
Subject Re: [RTC] ActiveMQ GBean modules
Date Sat, 17 Jun 2006 17:26:38 GMT
Ok.

That looks like 3 +1s now.  Committing patch shortly.  Thanks everybody!

On 6/17/06, Aaron Mulder <ammulder@alumni.princeton.edu> wrote:
> To clarify, I think David's comments are important, but I think the
> patch should go in and then be adjusted further.  I'd rather see
> iterative development in 1.2 and more effort to make the patch right
> the first time in 1.1.1.  There's no reason we couldn't open David's
> comments in a Jira when this patch is committed just to make sure we
> don't forget.
>
> We should also talk about whether to maintain this code in AMQ or
> Geronimo, but in parallel with any actual work on the code.
>
> Thanks,
>     Aaron
>
> On 6/17/06, Aaron Mulder <ammulder@alumni.princeton.edu> wrote:
> > +1 to your comment, +1 to the patch.  Let's get it in!  :)
> >
> > Thanks,
> >     Aaron
> >
> > On 6/17/06, Hiram Chirino <hiram@hiramchirino.com> wrote:
> > > HI,
> > >
> > > On 6/14/06, Aaron Mulder <ammulder@alumni.princeton.edu> wrote:
> > > > +1
> > > >
> > >
> > > Is this a vote for the patch or whas that a +1 on my last comment?
> > >
> > > Anyways.. I want to recap where the vote on this RTC is at.  After 12
> > > days, we have:
> > >
> > > +1 "from me, but I'm not sure it should get counted since I didn't
> > > apply the patch." - Dain
> > > +1, "looks fine to me." - James
> > > +0 "The spirit of the patch is great.  I haven't had the time to
> > > review it in detail." - Aaron
> > >
> > > And possibly a +1 from Aaron but I'm not sure what you were doing a +1 to.
> > >
> > > I don't understand how we can let such a small and simple gbean
> > > implementation sit so long.  I understand Geronimo is a big best and
> > > not everyone can be looking at everything all the time.  But if we
> > > don't make efforts to get the simple stuff done, we will never get
> > > past 1.1.
> > >
> > > --
> > > Regards,
> > > Hiram
> > >
> > > Blog: http://hiramchirino.com
> > >
> >
>


-- 
Regards,
Hiram

Blog: http://hiramchirino.com

Mime
View raw message