geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sachin Patel <>
Subject Re: [Vote: RTC] needed for eclipse plugin
Date Fri, 02 Jun 2006 14:37:30 GMT
FYI, I've already committed the change, and was gonna just run  
thought the entire source tree to update all copyrights for any file  
created this year.

On Jun 2, 2006, at 10:23 AM, Kevan Miller wrote:

> It seems that there are now +1's from 3 committers for this change.  
> Although I also support the change (once copyrights are corected),  
> I cannot offer a +1. Apologies for being a pedant, but to my  
> knowledge the current RTC "rules" we are living under are:
>   'I have applied this patch and tested it and found it good'
> I'm pretty sure that there's only one person who has done this and  
> his name is Sachin. Although it's likely that I could apply the  
> patch and build devtools, I wouldn't know how to integrate and test  
> the change.
> I think many of us feel that the requirement to apply and test a  
> patch is too restrictive and cumbersome -- especially in smaller  
> subprojects such as devtools and daytrader. Rather than ignoring  
> this directive, let's get the process changed or at least start a  
> discussion... I'll start a thread.
> --kevan
> On Jun 1, 2006, at 9:42 AM, Sachin Patel wrote:
>> The following big change is part 1 of 2 to correctly handle  
>> loading of the deployment plan editors.  To briefly summarize, the  
>> change introduces a new extension point which requires an  
>> implementation of IGeronimoFormContentLoader.  Previously the  
>> editor extension point loaded the editor for 1.0 plans.  Now the  
>> editor must handle multiple versions of the deployment plans so  
>> now there is a single editor extension def which loads a single  
>> editor impl, SharedDeploymentEditor which loads all the  
>> IGeronimoFormContent loaders (one impl for 1.0 and another for  
>> 1.1) and delegates to the appropriate emf models to generate the  
>> UI for the plans.  With this commit, the 1.0 plans load correctly  
>> and there is some work still need to be done for 1.1 to be done.   
>> There is currently some duplicate code which will need to be  
>> refactored, part 2 will address this, but since the patch is about  
>> 3000 lines I wanted to go ahead and commit.
>> Please vote...
>> Thanks.
>> <patch2.txt>
>> -sachin


View raw message